Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add notification or documentation for: Adding original entries to new group configuration unexpectedly modifies original entries #8911

Closed
2 tasks done
LIM0000 opened this issue Jun 20, 2022 · 5 comments · Fixed by #8919

Comments

@LIM0000
Copy link
Contributor

LIM0000 commented Jun 20, 2022

JabRef version

Latest development branch build (please note build date below)

Operating system

Windows

Details on version and operating system

Windows 10

Checked with the latest development build

  • I made a backup of my libraries before testing the latest development version.
  • I have tested the latest development version and the problem persists

Steps to reproduce the behaviour

Steps to reproduce:
Part 1:

  1. Create a new library.
  2. Click on Add group button.
  3. Input name test1 for the group and create the group.
  4. Create 2 articles in All entries.
  5. Input author field with steven and mike for each article respectively.

Part 2:

  1. Right click on test1 group -> Edit group
  2. Select Searching for a keyword under Collect by.
  3. Input author as field and steven as keyword, then click on ok button and ok button for warning dialog.
    (test1 group has a steven article entry)

Part 3:

  1. Right click on test1 group -> Edit group
  2. Select Searching for a keyword under Collect by.
  3. Input author as field and mike as keyword, then click on ok button and ok button for warning dialog.
    (test1 group now has 2 articles which are steven,mike and mike articles)

EXPECTED:
I am expecting that part 3 will return both `steven` and `mike` articles.

ACTUAL:
However, 1 of the articles' author field has been merged to steven,mike. Is this an expected behaviour?
From my understanding, Collect by should only return filtered entries without any entries modification.

111

Appendix

...

Log File
Paste an excerpt of your log file here
@ThiloteE ThiloteE added bug Confirmed bugs or reports that are very likely to be bugs groups entry-editor labels Jun 20, 2022
@ThiloteE
Copy link
Member

Could you please show what is in the {} biblatex source tab of all shown entries?

I have come across a similar odd behaviour (see #8527 (comment)), but back then, I was not able to reproduce with a fresh library.

@LIM0000
Copy link
Contributor Author

LIM0000 commented Jun 20, 2022

steven article (somehow merge into "steven, mike" after edited the group with searching keyword)

111

mike article

222

@LIM0000
Copy link
Contributor Author

LIM0000 commented Jun 21, 2022

I have done more researches to issue and understand what is happening behind the hood of the issue with Searching for a keyword.

When user edits a group from Explicit selection to Searching for a keyword, the group type changes from ExplicitGroup to WordKeywordGroup. This WordKeywordGroup functions DYNAMICALLY. Using example from above, we set the field as author and keyword as mike in WordKeywordGroup, this group will automatically assign ANY NEW entries that have author=mike into it.

However, if user assigns any entry that does not have author=mike and the group is WordKeywordGroup, the group will have to modify the field and the value of the entry. Using example from above again, we set the field as author and keyword as mike in WordKeywordGroup, if user "forcefully" assigns entry with author=steven into this group, it does not make sense for WordKeywordGroup as this entry does not have mike in it. Therefore, WordKeywordGroup will append mike into the entry's author field which results in author=steven, mike. Now the WordKeywordGroup able to add the entry into its group.

WordKeywordGroup behaves correctly. Although there is a warning dialog asking users whether they would like to assign the original group's entries to this group, there is no warning dialog about modifying users' entries.

111

@ThiloteE
Copy link
Member

ThiloteE commented Jun 21, 2022

Great!

I would suggest to append to the Change of Grouping Method: Assign the original group's entries to this group? dialogue the following notification:

(Note: If original entries lack keywords to qualify for the new group configuration, confirming here will add them)

Alternatively, this info could be added to JabRef's documentation (here)

@ThiloteE ThiloteE changed the title Collect by "Searching for a keyword" behaves unexpectedly Collect by "Searching for a keyword": Adding original entries to new group configuration unexpectedly modifies original entries Jun 21, 2022
@ThiloteE ThiloteE changed the title Collect by "Searching for a keyword": Adding original entries to new group configuration unexpectedly modifies original entries Add notification or documentation for: Adding original entries to new group configuration unexpectedly modifies original entries Jun 21, 2022
@ThiloteE ThiloteE added type: documentation and removed bug Confirmed bugs or reports that are very likely to be bugs labels Jun 21, 2022
LIM0000 added a commit to LIM0000/jabref that referenced this issue Jun 22, 2022
… dialog and append additional information for WordKeywordGroup
@Siedlerchr
Copy link
Member

Siedlerchr commented Jun 28, 2022

I was to free to fix the l10n tests and to make the buttons more explicit.

grafik

@Siedlerchr Siedlerchr added status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers and removed status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers labels Jun 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants