Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refine right click menu #9432

Closed
koppor opened this issue Dec 5, 2022 · 9 comments · Fixed by #10659
Closed

Refine right click menu #9432

koppor opened this issue Dec 5, 2022 · 9 comments · Fixed by #10659

Comments

@koppor
Copy link
Member

koppor commented Dec 5, 2022

Follow-up to #6601

We take Windows Explorer as reference (see #6601 (comment))

Current appearance:

grafik

Only columns enabled in the preferences are shown:

grafik

How to enable addition of new columns (as shown at the screenshot at #6601 (comment))?

We think "More..." ("Mehr..." in German) is missing:

grafik

After a click, a new popup opens

grafik

Would be nice if that was added here, too. Would that be possible?

This list should be filled with all fields known to JabRef. In case a user wants to add more fields, they must go to the preferences and add the custom field there.

@ilippert
Copy link
Contributor

I like to highlight that I think it is of key importance that indeed the user interacts with an overview of the other fields already available, before/when they want to add another field.

@dragos222
Copy link
Contributor

Hi, I would like to work on this issue. Could I please be assigned to it?

@ThiloteE
Copy link
Member

@dragos222 i will assign you to it, but I assume you are very new to coding, as there is very low amounts of activity in your github account. While I am happy you chose this issue, if you ever feel it is too hard for you, there is the possibility to choose another one from good first issues. Those are usually a little easier. If it were to turn out that way, just leave a short comment here and/or unassign yourself. Otherwise, gl & hf :-)

@ThiloteE ThiloteE moved this from Free to take to Reserved in Candidates for University Projects Mar 16, 2023
@ThiloteE ThiloteE added the FirstTimeCodeContribution Triggers GitHub Greeter Workflow label Mar 16, 2023
@github-actions
Copy link
Contributor

As a general advice for newcomers: check out Contributing for a start. Also, guidelines for setting up a local workspace is worth having a look at.

Feel free to ask here at GitHub, if you have any issue related questions. If you have questions about how to setup your workspace use JabRef's Gitter chat. Try to open a (draft) pull-request early on, so that people can see you are working on the issue and so that they can see the direction the pull request is heading towards. This way, you will likely receive valuable feedback.

@dragos222 dragos222 removed their assignment Mar 17, 2023
@ThiloteE ThiloteE moved this from Reserved to Free to take in Candidates for University Projects Mar 19, 2023
@ThiloteE ThiloteE removed the FirstTimeCodeContribution Triggers GitHub Greeter Workflow label Mar 19, 2023
@nikolaynikolaevn
Copy link

Hi! I am currently trying to complete this issue for a university project but I haven't asked to get assigned to it yet as I was not sure whether I could complete it soon. At this point, I think I think I am able to add a new right-click context menu item with custom logic (doing something else than enabling/disabling a table column).

My idea for the solution is to show a "More" option at the end of the current context menu that appears when right-clicking on a table column, and when the "More" option is selected, open the Preferences window at the "Entry table" tab, so that the existing functionality for managing the table columns shown can be reused. Is this solution proposal fine with you? If yes, is there some way to open the Preferences window at the "Entry table" tab from the code?

@ThiloteE
Copy link
Member

ThiloteE commented Mar 29, 2023

My idea for the solution is to show a "More" option at the end of the current context menu that appears when right-clicking on a table column, and when the "More" option is selected, open the Preferences window at the "Entry table" tab, so that the existing functionality for managing the table columns shown can be reused. Is this solution proposal fine with you? If yes, is there some way to open the Preferences window at the "Entry table" tab from the code?

@calixtus tagging you, because preferences related. Good idea or not?

@calixtus
Copy link
Member

Sounds like a very good solution.
There is not yet any functionality implemented, that would need to happen in some generic way...
This would probably be the greater part: to think of some nice solution for this. Maybe we can discuss this further, how to do that?

@theoo33
Copy link
Contributor

theoo33 commented Oct 17, 2023

Hi, if no one is currently working on this issue, my group and I (univ project) are interested in fixing it (probably by completing the latest proposal)
Thanks !

@calixtus
Copy link
Member

calixtus commented Oct 17, 2023

Yes, why not. A little bit guidance:
Please avoid creating cross dependencies between classes. My idea (i just had not time to implement it) would be to tell the prefs dialog constructor to show a tab of a certain Class<?> class (in this case something like ShowPreferencesAction(jabRefFrame, taskExecutor, TableTab.class), Let the Dialog look for the right one and show/focus it.

@ThiloteE ThiloteE moved this from Free to take to Reserved in Candidates for University Projects Oct 17, 2023
github-merge-queue bot pushed a commit that referenced this issue Nov 27, 2023
* add show more option in the right click main table header menu,
openingthe preferences

* comments

* Achieving contribution 2

* adjustments for right click menu on main table

* Update CHANGELOG.md for 9432

* PR test requirements

* Other PR requirements

* Other PR requirements

* remove optional from parameter

* openrewrite test

* openrewrite test

* change string to class for selection

* change string to class for selection

* remove comment + pass keybindings as parameter

* Update JabRef_en.properties

* Introduced StandardActions.withText

* Refactored for code maintenance

* Moved calls to frame out of PreferencesDialogView

---------

Co-authored-by: Théo Granier <theo.granier@imt-atlantique.net>
Co-authored-by: newma2n <hamidou.kane@imt-atlantique.net>
Co-authored-by: Carl Christian Snethlage <50491877+calixtus@users.noreply.github.com>
@github-project-automation github-project-automation bot moved this from Normal priority to Done in Features & Enhancements Nov 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment