Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dark Theme: Fix text-colour for non-attached files in file field of general tab #9481

Closed
ThiloteE opened this issue Dec 19, 2022 · 14 comments
Closed
Assignees
Labels
Dark Theme entry-editor FirstTimeCodeContribution Triggers GitHub Greeter Workflow good first issue An issue intended for project-newcomers. Varies in difficulty. ui

Comments

@ThiloteE
Copy link
Member

ThiloteE commented Dec 19, 2022

JabRef 5.8--2022-12-18--b7fae4b
Windows 10 10.0 amd64
Java 18.0.2.1
JavaFX 19+11

Light Theme:

image

Dark Theme:

image

How to reproduce:

  1. JabRef finds a file that COULD be attached (hence the orange background colour), but has not yet been attached, e.g. via regular expression search:
    image

  2. User has NOT YET clicked on the file that was found

@ThiloteE ThiloteE added ui entry-editor good first issue An issue intended for project-newcomers. Varies in difficulty. Dark Theme labels Dec 19, 2022
@ThiloteE ThiloteE changed the title Dark Theme: Fix text for non-attached files in file field of general tab Dark Theme: Fix text-colour for non-attached files in file field of general tab Dec 19, 2022
@ThiloteE
Copy link
Member Author

The regression was probably caused by #9340 or #9343

@Siedlerchr
Copy link
Member

For anyone looking into this:
It should look like this: PseudoClass opacity steers the highlighting if the file is found or not

PseudoClass opacity = PseudoClass.getPseudoClass("opacity");

grafik

When testing see also what happens when the file is selected or clicked

@2022H1030042G
Copy link

Hi, I would like to work on this issue, is it available?

@2022H1030042G
Copy link

I am new to this field, can you please guide me on this?

@ThiloteE ThiloteE added the FirstTimeCodeContribution Triggers GitHub Greeter Workflow label Jan 22, 2023
@github-actions
Copy link
Contributor

As a general advice for newcomers: check out Contributing for a start. Also, guidelines for setting up a local workspace is worth having a look at.

Feel free to ask here at GitHub, if you have any issue related questions. If you have questions about how to setup your workspace use JabRef's Gitter chat. Try to open a (draft) pull-request early on, so that people can see you are working on the issue and so that they can see the direction the pull request is heading towards. This way, you will likely receive valuable feedback.

@karan-prajapati-976
Copy link

I want to work on this issue please assign me this isuue

@ThiloteE
Copy link
Member Author

@2022H1030042G are you still on it?

@ThiloteE ThiloteE added the status: waiting-for-feedback The submitter or other users need to provide more information about the issue label Feb 22, 2023
@karan-prajapati-976
Copy link

Yes , im on it

@ThiloteE
Copy link
Member Author

For a lack of response, i will now assign @karan-prajapati-976

@ThiloteE ThiloteE removed the status: waiting-for-feedback The submitter or other users need to provide more information about the issue label Feb 26, 2023
@JawadTUE
Copy link
Contributor

Hi, can I be assigned to this issue? It is for a university project and we will try to resolve this issue in two weeks.

@ThiloteE
Copy link
Member Author

@karan-prajapati-976 I have seen within the last 3 weeks, there was 0 activity on your github account. If you have something, then please respond and create a pull-request within the next 24 hours. Otherwise, we will have to assume you have dropped this issue and I will assign @JawadTUE

@JawadTUE
Copy link
Contributor

Thank you, please let me know if I can be assigned to it.

@HoussemNasri
Copy link
Member

Hey @JawadTUE, the issue seems to have magically disappeared in the latest development version 😇. We apologize for the inconvenience. You are welcome to checkout other goodfirstisssues.

@koppor
Copy link
Member

koppor commented Apr 3, 2023

@JawadTUE A simple one can be #9732

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dark Theme entry-editor FirstTimeCodeContribution Triggers GitHub Greeter Workflow good first issue An issue intended for project-newcomers. Varies in difficulty. ui
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

7 participants