Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tests #10236

Merged
merged 3 commits into from
Aug 29, 2023
Merged

Fix tests #10236

merged 3 commits into from
Aug 29, 2023

Conversation

koppor
Copy link
Member

@koppor koppor commented Aug 29, 2023

Follow-up to #10227.

Was too late yesterday ^^

Mandatory checks

  • Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
  • Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

@koppor koppor added the SLR label Aug 29, 2023
@JabRef JabRef deleted a comment from github-actions bot Aug 29, 2023
@koppor koppor marked this pull request as ready for review August 29, 2023 08:07
@github-actions
Copy link
Contributor

github-actions bot commented Aug 29, 2023

The build for this PR is no longer available. Please visit https://builds.jabref.org/main/ for the latest build.

@Siedlerchr
Copy link
Member

But then please remove the jspecify stuff. I have headaches having this in the release witthout knowing about possible NPE consequences

@koppor
Copy link
Member Author

koppor commented Aug 29, 2023

It's a design-time only annotation without any injected runtime effects. I nevertheless removed it at #10240.

@Siedlerchr Siedlerchr merged commit 3fda8ef into main Aug 29, 2023
@Siedlerchr Siedlerchr deleted the fix-slr-test branch August 29, 2023 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants