-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add workaround for IDEA-317606 #10322
Conversation
Closed IntelliJ, deleted Works now I would more like to use -rootProject.name = "JabRef"
+rootProject.name = "jabref" |
not sure if this will affect our installer/deployment scripts etc |
Maybe we just try in this PR? -- I pushed the change in |
The application name is NOT reused from there, but hard coded in the launcher part of jlink: Line 554 in 9c4ca38
(Documentation at https://badass-jlink-plugin.beryx.org/releases/latest/ -> section "Launcher") |
The build for this PR is no longer available. Please visit https://builds.jabref.org/main/ for the latest build. |
This reverts commit 5a3dc4e.
…nto fix-dependency-conflicts * 'fix-dependency-conflicts' of github.com:JabRef/jabref: test updating javafx plugin but throws at runtime Revert "Add workaround for IDEA-317606 (#10322)" Add workaround for IDEA-317606 (#10322) New Crowdin updates (#10335) Add change in en.properties as well Correction of a typo in LinkedFileViewModel.java Fix devcontainer prebuilds (#10333) Add requires on org.freedesktop.dbus (#10332) Fix hint to menu
When starting from scratch in IntelliJ, one might see
java.lang.IllegalStateException: Module entity with name: jabref.main should be available
. See IDEA-317606 for details.This PR adds a work around (update): by changing
settings.gradle
.The underlying issue is that in
settings.gradle
, we currently haveJabRef
as project name. However, our source repository is calledjabref
, which is not the same casing. This started to confuse IntelliJ.Mandatory checks
CHANGELOG.md
described in a way that is understandable for the average user (if applicable)