Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Close pop over early #10477

Merged
merged 1 commit into from
Oct 10, 2023
Merged

Close pop over early #10477

merged 1 commit into from
Oct 10, 2023

Conversation

koppor
Copy link
Member

@koppor koppor commented Oct 10, 2023 •
edited
Loading

Sometimes on MacOSX, the pop over sometimes closes without pressing enter. This is a work around to avoid "duplicate entry" dialog in case of adding a DOI.

Now, when JabRef notifies about the search, the pop over is closed.

Before, the popup was closed after the search (independent of if there was an error or not)

image

Mandatory checks

  • Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
  • Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

@koppor @0x002A
Close pop over early
3e85672 
Co-authored-by: Kevin Klein <kevin@0x002a.com>
@github-actions
Copy link
Contributor

github-actions bot commented Oct 10, 2023 •
edited
Loading

The build for this PR is no longer available. Please visit https://builds.jabref.org/main/ for the latest build.

@Siedlerchr Siedlerchr added this pull request to the merge queue Oct 10, 2023
Merged via the queue into main with commit c444c73 Oct 10, 2023
14 checks passed
@Siedlerchr Siedlerchr deleted the close-popup-early branch October 10, 2023 20:55
Siedlerchr added a commit that referenced this pull request Oct 11, 2023
@Siedlerchr
Merge remote-tracking branch 'upstream/main' into fixBrowserOpening
7d7ed71 
* upstream/main:
  Add fields to CrossRef  (#10469)
  move changelog entry
  Close pop over early (#10477)
  This sets focus to new library (#10468)
  Polish AUX file import dialog (#10473)
  update gradle (#10471)

# Conflicts:
#	CHANGELOG.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Siedlerchr Siedlerchr Siedlerchr approved these changes

Assignees
No one assigned
Labels
os: macOS ui
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@koppor @Siedlerchr