Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix adding index column due to no qualifer property #10527

Merged
merged 2 commits into from
Oct 21, 2023
Merged

Fix adding index column due to no qualifer property #10527

merged 2 commits into from
Oct 21, 2023

Conversation

Siedlerchr
Copy link
Member

Found while testing https://discourse.jabref.org/t/does-the-field-still-exist/4029

Mandatory checks

  • Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
  • Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 19, 2023 •
edited
Loading

The build for this PR is no longer available. Please visit https://builds.jabref.org/main/ for the latest build.

@Siedlerchr
Copy link
Member Author

Probably not necessary

@calixtus
Copy link
Member

? So whats the real problem here?

@Siedlerchr
Copy link
Member Author

The guy in the forum said it worked for him

@calixtus calixtus marked this pull request as draft October 21, 2023 20:52
@koppor
Copy link
Member

koppor commented Oct 21, 2023

Tried here. Windows 10. Did not work on main, works with this PR.

@Siedlerchr Siedlerchr marked this pull request as ready for review October 21, 2023 21:15
@koppor koppor enabled auto-merge October 21, 2023 21:15
@Siedlerchr Siedlerchr removed the request for review from calixtus October 21, 2023 21:40
@Siedlerchr Siedlerchr merged commit 1da8ede into main Oct 21, 2023
12 of 15 checks passed
@Siedlerchr Siedlerchr deleted the fixaddingIndexColumn branch October 21, 2023 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@koppor koppor koppor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Siedlerchr @calixtus @koppor