Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split Java code style checks #10532

Merged
merged 2 commits into from
Oct 21, 2023
Merged

Split Java code style checks #10532

merged 2 commits into from
Oct 21, 2023

Conversation

koppor
Copy link
Member

@koppor koppor commented Oct 21, 2023

It is hard for newcomers to know about that we have more than checkstyle in place. See #10496 (comment).

We (currently) don't have it in the documentation. This is future work.

I think, it is more helpful, if we automatically comment on the PR to support tailored guidance. This PR tries to do it.

Mandatory checks

  • Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
  • Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

Siedlerchr
Siedlerchr previously approved these changes Oct 21, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Oct 21, 2023

The build for this PR is no longer available. Please visit https://builds.jabref.org/main/ for the latest build.

@koppor
Copy link
Member Author

koppor commented Oct 21, 2023

Build hangs, because I renamed the tests (to be more fine grained).

Will merge and then adapt our CI requirements. Thus, all PRs need to merge main.

@koppor koppor disabled auto-merge October 21, 2023 10:32
@koppor koppor merged commit 003cdcc into main Oct 21, 2023
18 of 20 checks passed
@koppor koppor deleted the split-code-quality-steps branch October 21, 2023 10:32
@koppor
Copy link
Member Author

koppor commented Oct 21, 2023

For reference, new branch protection rules:

image

@koppor
Copy link
Member Author

koppor commented Oct 24, 2023

For reference, this is the output if something is really wrong - source: #10571 (comment)

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants