Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace "fixes" by "closes" #10581

Merged
merged 6 commits into from
Oct 26, 2023
Merged

Replace "fixes" by "closes" #10581

merged 6 commits into from
Oct 26, 2023

Conversation

koppor
Copy link
Member

@koppor koppor commented Oct 25, 2023

Multiple contributors did not use "fixes", but other words (not recognized by GitHub https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue)

The explanation seems to be that "fixes" is interpreted as fixing a bug only. Thus, they changed the wording. See koppor#540 (comment) for that explanation.

"Resolves" has more weight to me than "Closes". However, GitHub has "Close" at issues, therefore, I propose to use "Closes" as text.

Mandatory checks

  • Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
  • Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

Copy link
Member

@k3KAW8Pnf7mkmdSMPHz27 k3KAW8Pnf7mkmdSMPHz27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really dislike "Closes" but I agree with the logic.

.github/PULL_REQUEST_TEMPLATE.md Outdated Show resolved Hide resolved
koppor and others added 2 commits October 25, 2023 22:31
Co-authored-by: Jonatan Asketorp <jonatan.asketorp@proton.me>
@koppor koppor changed the title Replace "fixes" by "resolves" Replace "fixes" by "closes" Oct 25, 2023
@k3KAW8Pnf7mkmdSMPHz27
Copy link
Member

Wait a sec.

@k3KAW8Pnf7mkmdSMPHz27
Copy link
Member

I think the editor helpfully added something there for me, my bad for not double checking

@Siedlerchr
Copy link
Member

I prefer fixes as well, but closes is fine for me ... And I will continue to use FIxes

@k3KAW8Pnf7mkmdSMPHz27
Copy link
Member

k3KAW8Pnf7mkmdSMPHz27 commented Oct 25, 2023

I prefer fixes as well, but closes is fine for me ... And I will continue to use FIxes

I'll be contrarian and start using Resolves 😎

Some are better for different contexts, and I think Closes might just be the weirdest except for the reference to the GitHub UI.

@Siedlerchr
Copy link
Member

I prefer fixes as well, but closes is fine for me ... And I will continue to use FIxes

I'll be contrarian and start using Resolves 😎

Some are better for different contexts, and I think Closes might just be the weirdest except for the reference to the GitHub UI.

+1 for resolves!

Co-authored-by: Jonatan Asketorp <jonatan.asketorp@proton.me>
@github-actions
Copy link
Contributor

github-actions bot commented Oct 25, 2023

The build for this PR is no longer available. Please visit https://builds.jabref.org/main/ for the latest build.

@Siedlerchr Siedlerchr added this pull request to the merge queue Oct 26, 2023
Siedlerchr
Siedlerchr previously approved these changes Oct 26, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 26, 2023
@Siedlerchr Siedlerchr merged commit 8804fac into main Oct 26, 2023
12 of 15 checks passed
@Siedlerchr Siedlerchr deleted the change-pr-template branch October 26, 2023 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants