-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace "fixes" by "closes" #10581
Replace "fixes" by "closes" #10581
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I really dislike "Closes" but I agree with the logic.
Co-authored-by: Jonatan Asketorp <jonatan.asketorp@proton.me>
Wait a sec. |
I think the editor helpfully added something there for me, my bad for not double checking |
I prefer fixes as well, but closes is fine for me ... And I will continue to use FIxes |
I'll be contrarian and start using Resolves 😎 Some are better for different contexts, and I think Closes might just be the weirdest except for the reference to the GitHub UI. |
+1 for resolves! |
Co-authored-by: Jonatan Asketorp <jonatan.asketorp@proton.me>
The build for this PR is no longer available. Please visit https://builds.jabref.org/main/ for the latest build. |
Multiple contributors did not use "fixes", but other words (not recognized by GitHub https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue)
The explanation seems to be that "fixes" is interpreted as fixing a bug only. Thus, they changed the wording. See koppor#540 (comment) for that explanation.
"Resolves" has more weight to me than "Closes". However, GitHub has "Close" at issues, therefore, I propose to use "Closes" as text.
Mandatory checks
CHANGELOG.md
described in a way that is understandable for the average user (if applicable)