-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
replace "SearchAll" in web search by "Search Selected" #10611
Merged
Siedlerchr
merged 10 commits into
JabRef:main
from
lisongxuan:Issue#10556-Search-Selected
Nov 9, 2023
Merged
replace "SearchAll" in web search by "Search Selected" #10611
Siedlerchr
merged 10 commits into
JabRef:main
from
lisongxuan:Issue#10556-Search-Selected
Nov 9, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
see:JabRef#10556 Implemented "Search Selected". Enabled configuring the catalogs to be searched. Updated menu and other corresponding UI Updated corresponding tests
No clue about what happened to fetcher tests:( any help is appreciated! |
Siedlerchr
reviewed
Nov 1, 2023
src/main/java/org/jabref/logic/importer/ImporterPreferences.java
Outdated
Show resolved
Hide resolved
Siedlerchr
reviewed
Nov 1, 2023
src/main/java/org/jabref/gui/importer/fetcher/WebSearchPaneViewModel.java
Outdated
Show resolved
Hide resolved
Siedlerchr
reviewed
Nov 1, 2023
src/main/java/org/jabref/gui/importer/fetcher/WebSearchPaneViewModel.java
Outdated
Show resolved
Hide resolved
Siedlerchr
reviewed
Nov 1, 2023
src/main/java/org/jabref/gui/preferences/websearch/WebSearchTabViewModel.java
Outdated
Show resolved
Hide resolved
Siedlerchr
requested changes
Nov 1, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks already good, just a few code style things
Siedlerchr
reviewed
Nov 1, 2023
src/test/java/org/jabref/logic/importer/fetcher/CompositeSearchBasedFetcherTest.java
Outdated
Show resolved
Hide resolved
koppor
previously requested changes
Nov 2, 2023
src/main/java/org/jabref/gui/preferences/websearch/WebSearchTab.fxml
Outdated
Show resolved
Hide resolved
src/main/java/org/jabref/logic/importer/fetcher/CompositeSearchBasedFetcher.java
Outdated
Show resolved
Hide resolved
src/main/java/org/jabref/logic/importer/fetcher/CompositeSearchBasedFetcher.java
Outdated
Show resolved
Hide resolved
src/main/java/org/jabref/logic/importer/fetcher/CompositeSearchBasedFetcher.java
Outdated
Show resolved
Hide resolved
src/main/java/org/jabref/logic/importer/fetcher/CompositeSearchBasedFetcher.java
Outdated
Show resolved
Hide resolved
src/test/java/org/jabref/gui/slr/ManageStudyDefinitionViewModelTest.java
Show resolved
Hide resolved
src/test/java/org/jabref/logic/crawler/StudyCatalogToFetcherConverterTest.java
Outdated
Show resolved
Hide resolved
src/test/java/org/jabref/logic/importer/fetcher/CompositeSearchBasedFetcherTest.java
Outdated
Show resolved
Hide resolved
…Selected * upstream/main: Update to JavaFX 21.01 (JabRef#10627) Fix JabRef#10498 Create Fetcher and Transformer for ScholarArchive (JabRef#10549) fix tests Bump org.jsoup:jsoup from 1.16.1 to 1.16.2 (JabRef#10625) Bump org.junit.jupiter:junit-jupiter from 5.10.0 to 5.10.1 Bump org.fxmisc.flowless:flowless from 0.7.1 to 0.7.2 Bump com.dlsc.gemsfx:gemsfx from 1.84.0 to 1.90.0 Bump com.tngtech.archunit:archunit-junit5-api from 1.1.0 to 1.2.0 Change linter (JabRef#10614)
Remove whitespace
calixtus
approved these changes
Nov 9, 2023
Siedlerchr
approved these changes
Nov 9, 2023
Siedlerchr
added a commit
to xuanan20020/jabref
that referenced
this pull request
Nov 10, 2023
* upstream/main: (24 commits) Add support for scite.ai (JabRef#10617) Update tests.yml (JabRef#10631) replace "SearchAll" in web search by "Search Selected" (JabRef#10611) Use System preference for light dark theme (JabRef#10593) Fix NPE in lookup identifer Add minimum requirements to CHANGELOG.md (JabRef#10628) Update to JavaFX 21.01 (JabRef#10627) Fix JabRef#10498 Create Fetcher and Transformer for ScholarArchive (JabRef#10549) fix tests Bump org.jsoup:jsoup from 1.16.1 to 1.16.2 (JabRef#10625) Bump org.junit.jupiter:junit-jupiter from 5.10.0 to 5.10.1 Bump org.fxmisc.flowless:flowless from 0.7.1 to 0.7.2 Bump com.dlsc.gemsfx:gemsfx from 1.84.0 to 1.90.0 Bump com.tngtech.archunit:archunit-junit5-api from 1.1.0 to 1.2.0 Change linter (JabRef#10614) change codecov (JabRef#10616) Add entry based on ISSN number JabRef#10124 (JabRef#10178) Enable journal information fetcher directly in popup (JabRef#10598) Make generate button wider (JabRef#10588) make openRewrite stable again ... # Conflicts: # CHANGELOG.md # src/main/resources/l10n/JabRef_en.properties
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #10556
Implemented "Search Selected".
Enabled configuring the catalogs to be searched.
Updated menu and other corresponding UI
Updated corresponding tests
Mandatory checks
CHANGELOG.md
described in a way that is understandable for the average user (if applicable)