Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix color for hovered special fields #10742

Merged
merged 5 commits into from
Jan 2, 2024
Merged

Fix color for hovered special fields #10742

merged 5 commits into from
Jan 2, 2024

Conversation

koppor
Copy link
Member

@koppor koppor commented Jan 2, 2024 •
edited
Loading

Old:

grafik

New:

grafik

Fixes #10431

Follow-up to #10620

Mandatory checks

  • Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
  • Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

koppor and others added 4 commits January 2, 2024 21:41
@koppor
Fix typo
a6cd807
@koppor
Do not use null
227cb3f
@koppor
Fix indent
e4472cd
@koppor @Siedlerchr
Add missing CSS class
ffa6fcf 
Co-authored-by: Christoph <siedlerkiller@gmail.com>
Siedlerchr
Siedlerchr previously approved these changes Jan 2, 2024
View reviewed changes
@Siedlerchr Siedlerchr added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Jan 2, 2024
@koppor koppor enabled auto-merge January 2, 2024 20:52
@koppor koppor added this pull request to the merge queue Jan 2, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 2, 2024 •
edited
Loading

The build for this PR is no longer available. Please visit https://builds.jabref.org/main/ for the latest build.

Merged via the queue into main with commit 44d646e Jan 2, 2024
19 checks passed
@koppor koppor deleted the fix-10431 branch January 2, 2024 21:10
Siedlerchr added a commit that referenced this pull request Jan 3, 2024
@Siedlerchr
Merge remote-tracking branch 'upstream/main' into fixDuplicateUmlauts
8217d5b 
* upstream/main:
  Ignore 429 at link check (#10743)
  Fix color for hovered special fields (#10742)

# Conflicts:
#	CHANGELOG.md
Siedlerchr added a commit that referenced this pull request Jan 3, 2024
@Siedlerchr
Merge branch 'main' of github.com:JabRef/jabref
ad80390 
* 'main' of github.com:JabRef/jabref:
  Ignore 429 at link check (#10743)
  Fix color for hovered special fields (#10742)
  Adds three tests to verify the expected output from the getErroMessage function. The tests check the output message when ParserResult is empty, not empty, or has duplicates. (#10711)
  Extract calls to JabRefFrame and substitute with LibraryTabContainer (#10724)
Siedlerchr added a commit that referenced this pull request Jan 12, 2024
@Siedlerchr
Merge remote-tracking branch 'upstream/main' into allEntriesDuplicates
42774ed 
* upstream/main:
  Fix duplicate checker does not respect umlauts / latex free fields  (#10744)
  Ignore 429 at link check (#10743)
  Fix color for hovered special fields (#10742)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Siedlerchr Siedlerchr Siedlerchr approved these changes

Assignees
No one assigned
Labels
status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Relevance star should only appear when toggled
2 participants
@koppor @Siedlerchr