Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add group icon column #10801

Merged
merged 5 commits into from
Jan 24, 2024
Merged

Add group icon column #10801

merged 5 commits into from
Jan 24, 2024

Conversation

Siedlerchr
Copy link
Member

@Siedlerchr Siedlerchr commented Jan 17, 2024 •
edited
Loading

Fixes https://github.com/JabRef/jabref-issue-melting-pot/issues/343

grafik

Mandatory checks

  • Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
  • Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

@Siedlerchr Siedlerchr added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Jan 17, 2024
@koppor
Copy link
Member

koppor commented Jan 22, 2024

Thank you! 🎉

  1. Why does the new group column appear as last in the column choice? It should IMHO appear directly after "Group"

image

  1. The icon for the main table should be different

image

The "tag" icon is OK for the new column.

Maybe, change the icon for groups? To a folder icon?

  1. When resetting the preferences, the group icon colum should appear directly after the group color column.

@Siedlerchr
Merge remote-tracking branch 'upstream/main' into groupIconColumn
65753ab 
* upstream/main:
  Bump com.puppycrawl.tools:checkstyle from 10.12.5 to 10.12.7 (#10812)
  Bump DavidAnson/markdownlint-cli2-action from 14 to 15 (#10816)
  Bump actions/cache from 3 to 4 (#10815)
  Bump org.gradle.toolchains.foojay-resolver-convention (#10811)
  Bump org.slf4j:slf4j-api from 2.0.9 to 2.0.11 (#10810)
  Bump org.apache.logging.log4j:log4j-to-slf4j from 2.21.1 to 2.22.1 (#10814)
  Update to javafx 21.0.2 (#10808)
@Siedlerchr
Add column as default to preferences
045c167 
change icon
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 23, 2024 •
edited
Loading

The build for this PR is no longer available. Please visit https://builds.jabref.org/main/ for the latest build.

@Siedlerchr
Copy link
Member Author

@koppor Changed the position and icon. If you reset your prefs it will be shown

@Siedlerchr Siedlerchr added this pull request to the merge queue Jan 24, 2024
Merged via the queue into main with commit 6697302 Jan 24, 2024
18 of 19 checks passed
@Siedlerchr Siedlerchr deleted the groupIconColumn branch January 24, 2024 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@koppor koppor koppor approved these changes

Assignees
No one assigned
Labels
status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Siedlerchr @koppor