-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve CFF import/export and craft a round-trip test #10995
Commits on Mar 12, 2024
-
issue #10993 - feat: added ability to parse preferred-citation field …
…to CffImporter
Configuration menu - View commit details
-
Copy full SHA for f437d58 - Browse repository at this point
Copy the full SHA f437d58View commit details -
Configuration menu - View commit details
-
Copy full SHA for b5298df - Browse repository at this point
Copy the full SHA b5298dfView commit details -
issue #10993 - feat: rewrote CffExporter to parse Software, Dataset t…
…ypes and authors names correctly
Configuration menu - View commit details
-
Copy full SHA for a6b62e1 - Browse repository at this point
Copy the full SHA a6b62e1View commit details -
Configuration menu - View commit details
-
Copy full SHA for cd94d33 - Browse repository at this point
Copy the full SHA cd94d33View commit details -
Configuration menu - View commit details
-
Copy full SHA for ca0f887 - Browse repository at this point
Copy the full SHA ca0f887View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0b1b578 - Browse repository at this point
Copy the full SHA 0b1b578View commit details
Commits on Mar 15, 2024
-
Configuration menu - View commit details
-
Copy full SHA for d32d26f - Browse repository at this point
Copy the full SHA d32d26fView commit details
Commits on Mar 18, 2024
-
Convert RemoveBracesFormatterTest to @ParameterizedTest (#11033)
* Convert to @ParameterizedTest * Convert to csvsource --------- Co-authored-by: Carl Christian Snethlage <50491877+calixtus@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for 56bf7e7 - Browse repository at this point
Copy the full SHA 56bf7e7View commit details -
Importing of BibDesk Groups and Linked Files (#10968)
* Add test to check parsing of BibDesk Static Groups * Add test to check parsing of BibDesk Static Groups * Change isExpanded attribute to false in expected groups * remove extra blank line * Add tests to check parsing of BibDesk Smart and mixed groups * Add parsing of BibDesk Files * Attempts at plist * Now parses bdsk-file and shows it as a file in JabRef * Add test for parsing a bdsk-file field * Fix formatting * Add dd-plist library to documentation --------- Co-authored-by: Tian0602 <646432316@qq.com> * Add creation of static JabRef group from a BibDesk file * Creates an empty ExplicitGroup from BibDesk comment * Adds citations to new groups modifies group creations to support multiple groups in the same BibDeskFile * Fix requested changes Refactor imports since they did not match with main Add safety check in addBibDeskGroupEntriesToJabRefGroups --------- Co-authored-by: Filippa Nilsson <filnils@kth.se> * Refactor newline to match main branch Co-authored-by: Filippa Nilsson <filnils@kth.se> * Add changes to CHANGELOG.md * Reformat indentation to match previous * Revert external libraries Adjust groups serializing * checkstyle and optional magic * fix * fix tests * fix * fix dangling do * better group tree metadata setting * merge group trees, prevent duplicate group assignment in entry Add new BibDesk group Fix IOB for change listeing * fix tests, and extract constant * return early * fixtest and checkstyle --------- Co-authored-by: Anna Maartensson <120831475+annamaartensson@users.noreply.github.com> Co-authored-by: Tian0602 <646432316@qq.com> Co-authored-by: LottaJohnsson <35195355+LottaJohnsson@users.noreply.github.com> Co-authored-by: Filippa Nilsson <filnils@kth.se> Co-authored-by: Filippa Nilsson <75281470+filippanilsson@users.noreply.github.com> Co-authored-by: Oliver Kopp <kopp.dev@gmail.com> Co-authored-by: Siedlerchr <siedlerkiller@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for c4b2328 - Browse repository at this point
Copy the full SHA c4b2328View commit details -
Configuration menu - View commit details
-
Copy full SHA for 57f8a63 - Browse repository at this point
Copy the full SHA 57f8a63View commit details -
Fixes Zotero file handling for absolute paths (#11038)
* Fixes Zotero file handling for absolute paths Fixes #10959 * checkstyle mimiimm * fix changelog * cannot fix
Configuration menu - View commit details
-
Copy full SHA for 7a4be6d - Browse repository at this point
Copy the full SHA 7a4be6dView commit details -
Change copy-paste function to handle string constants (follow up PR) (#…
…11037) * [Copy] Include string constants in copy (#11) Signed-off-by: Anders Blomqvist <anders@minaemail.se> * [Copy] New method for serializing string constants (#12) Signed-off-by: Anders Blomqvist <anders@minaemail.se> * Add a sanity check for null for clipboard content Currenlty, the clipboard content can be null since the database does not seem to be updating. This is a sanity check to prevent the program from adding null to the clipboard. Link to DD2480-Group1#13 * [Fix] Add parsed serilization when save settings When loading from existing files or libraries, the parser will set the serilization of the string constant to the correct value. However, when editing via the GUI, the serilization was not set and a new string constant list will be created without the serilization. This result in the serilization being null and when copying with the clipboard. Link to DD2480-Group1#13 * feat: import string constants when pasting #9 Add functionality to import string constants in the paste function Should add functionality to handle colliding string constants. Should also check that the constants are valid using the ConstantsItemModel class. * feat: Add string constant validity checker and dialog messages #9 Check that a pasted string constant is valid using the ConstantsItemModel class. Add diagnostic messages notifying users when adding a string constant fails while pasting. * [Copy] Copy referenced constant strings to clipboard (#16) * feat: Add parsed serialized string when cloning * feat: Add sanity check for null in ClipBoardManager * closes #15 * feat: new unit tests Add 4 new unit tests, testing the new features added for issue-10872. Specifically the tests are for the `storeSettings` method in the ConstantsPropertiesViewModel.java, and `setContent` in the ClipBaordManager.java. Closes #6 * Update CHANGELOG with copy and paste function * Fix Checkstyle failing by reformat the code * Fix OpenRewrite failing by running rewriteRun * Refactor by extract methods in setContent * collet failures * changelog and use os.newline * checkstyle * use real bibentrytypes manager * Fix CHANGELOG.md * Swap if branches * Code cleanup * Use List for getUsedStringValues * Fix submodule * Collection is better * Fix csl-styles * Remove empty line * Group BibTeX string l10n together --------- Signed-off-by: Anders Blomqvist <anders@minaemail.se> Co-authored-by: Anders Blomqvist <anders@minaemail.se> Co-authored-by: ZOU Hetai <33616271+JXNCTED@users.noreply.github.com> Co-authored-by: Hannes Stig <hannes.a.stig@gmail.com> Co-authored-by: Elliot <elliot.darth@gmail.com> Co-authored-by: Oliver Kopp <kopp.dev@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 7abf13d - Browse repository at this point
Copy the full SHA 7abf13dView commit details -
Bump gittools/actions from 0.13.4 to 1.1.1 (#11039)
Bumps [gittools/actions](https://github.com/gittools/actions) from 0.13.4 to 1.1.1. - [Release notes](https://github.com/gittools/actions/releases) - [Commits](GitTools/actions@v0.13.4...v1.1.1) --- updated-dependencies: - dependency-name: gittools/actions dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for 9587520 - Browse repository at this point
Copy the full SHA 9587520View commit details -
Bump com.googlecode.plist:dd-plist from 1.23 to 1.28 (#11040)
Bumps [com.googlecode.plist:dd-plist](https://github.com/3breadt/dd-plist) from 1.23 to 1.28. - [Release notes](https://github.com/3breadt/dd-plist/releases) - [Commits](3breadt/dd-plist@dd-plist-1.23...v1.28.0) --- updated-dependencies: - dependency-name: com.googlecode.plist:dd-plist dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for 1ec6a6e - Browse repository at this point
Copy the full SHA 1ec6a6eView commit details -
Bump org.apache.pdfbox:xmpbox from 3.0.1 to 3.0.2 (#11041)
Bumps org.apache.pdfbox:xmpbox from 3.0.1 to 3.0.2. --- updated-dependencies: - dependency-name: org.apache.pdfbox:xmpbox dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for 930a9b4 - Browse repository at this point
Copy the full SHA 930a9b4View commit details -
Bump com.dlsc.gemsfx:gemsfx from 2.2.0 to 2.4.0 (#11044)
Bumps [com.dlsc.gemsfx:gemsfx](https://github.com/dlsc-software-consulting-gmbh/GemsFX) from 2.2.0 to 2.4.0. - [Release notes](https://github.com/dlsc-software-consulting-gmbh/GemsFX/releases) - [Changelog](https://github.com/dlsc-software-consulting-gmbh/GemsFX/blob/master/CHANGELOG.md) - [Commits](dlsc-software-consulting-gmbh/GemsFX@v2.2.0...v2.4.0) --- updated-dependencies: - dependency-name: com.dlsc.gemsfx:gemsfx dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for 5858598 - Browse repository at this point
Copy the full SHA 5858598View commit details -
Bump org.apache.pdfbox:fontbox from 3.0.1 to 3.0.2 (#11042)
Bumps org.apache.pdfbox:fontbox from 3.0.1 to 3.0.2. --- updated-dependencies: - dependency-name: org.apache.pdfbox:fontbox dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for 7cb8885 - Browse repository at this point
Copy the full SHA 7cb8885View commit details -
Keep enclosing braces of authors (#11034)
* Add test cases * Add test cases * Keep braces for last part * Refine method description * Adapt test to new braces keeping * Add CHANGELOG.md entry * Adapt tests * More edge cases * Minor code beautification * Simplify code * Fix braces removing * Extract static fields, refactor code * Fix removal of {} for export * Re-add Objects.requireNonNull * Fix typo * Re-add NPE throwing * Rename to modern terms * Consistent initialization
Configuration menu - View commit details
-
Copy full SHA for 342cb24 - Browse repository at this point
Copy the full SHA 342cb24View commit details -
Improve citation relations (#11016)
* Collect DOI and publication type from semantich scholar to be able to expand the information of the new entries later by search through DOI * Include abstract in the request. This lets the GUI show the abstract since that was implemented already. Refactor api request string since most of it is shared * Add button to open the relation paper's DOI URL. Fix DOI for some ArXiv entries. * Don't show the open link button if there is no link to open. * Make field value null error a bit more useful * Include SemanticScholar url in the request and use it as the URL field. * Add changes to changelog * Change tooltip text to an existing, more informative one * Run rewriter to fix pull request * improve url optional handling --------- Co-authored-by: Siedlerchr <siedlerkiller@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 5ab2a81 - Browse repository at this point
Copy the full SHA 5ab2a81View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7a269d4 - Browse repository at this point
Copy the full SHA 7a269d4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8a8434a - Browse repository at this point
Copy the full SHA 8a8434aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 008472b - Browse repository at this point
Copy the full SHA 008472bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 6f925ec - Browse repository at this point
Copy the full SHA 6f925ecView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5a60aff - Browse repository at this point
Copy the full SHA 5a60affView commit details -
Configuration menu - View commit details
-
Copy full SHA for 8fbdf26 - Browse repository at this point
Copy the full SHA 8fbdf26View commit details
Commits on Mar 19, 2024
-
fix: added requested changes (#10995)
+ updated CHANGELOG.md + removed useless comments + refactored both CffImporter and CffExporter to use more specific methods + used a BiMap to avoid repeating mappings between CffImporter and CffExporter + copied entryMap in exporter to avoid side-effects
Configuration menu - View commit details
-
Copy full SHA for 5e697a2 - Browse repository at this point
Copy the full SHA 5e697a2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 88c42b8 - Browse repository at this point
Copy the full SHA 88c42b8View commit details -
Configuration menu - View commit details
-
Copy full SHA for e1b1665 - Browse repository at this point
Copy the full SHA e1b1665View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9271368 - Browse repository at this point
Copy the full SHA 9271368View commit details -
Configuration menu - View commit details
-
Copy full SHA for 69245be - Browse repository at this point
Copy the full SHA 69245beView commit details
Commits on Mar 20, 2024
-
Configuration menu - View commit details
-
Copy full SHA for ad2d600 - Browse repository at this point
Copy the full SHA ad2d600View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6978078 - Browse repository at this point
Copy the full SHA 6978078View commit details -
Configuration menu - View commit details
-
Copy full SHA for ca9c0dc - Browse repository at this point
Copy the full SHA ca9c0dcView commit details -
Configuration menu - View commit details
-
Copy full SHA for 359237d - Browse repository at this point
Copy the full SHA 359237dView commit details -
Configuration menu - View commit details
-
Copy full SHA for a8518b7 - Browse repository at this point
Copy the full SHA a8518b7View commit details -
fix: fixed requested changes (#10995)
+ fixed typo in CHANGELOG.md + tested multiline abstract in CFFImporter
Configuration menu - View commit details
-
Copy full SHA for 0264c03 - Browse repository at this point
Copy the full SHA 0264c03View commit details
Commits on Mar 21, 2024
-
Configuration menu - View commit details
-
Copy full SHA for c4bc13c - Browse repository at this point
Copy the full SHA c4bc13cView commit details -
Configuration menu - View commit details
-
Copy full SHA for de27eef - Browse repository at this point
Copy the full SHA de27eefView commit details -
fix: fixed typos in MADR decision doc for CFF export and refactore Im…
…portFormatReader signature (#10995)
Configuration menu - View commit details
-
Copy full SHA for 2450c80 - Browse repository at this point
Copy the full SHA 2450c80View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8d72c5f - Browse repository at this point
Copy the full SHA 8d72c5fView commit details -
Configuration menu - View commit details
-
Copy full SHA for bf9ff8b - Browse repository at this point
Copy the full SHA bf9ff8bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 447632b - Browse repository at this point
Copy the full SHA 447632bView commit details -
Configuration menu - View commit details
-
Copy full SHA for c43d14a - Browse repository at this point
Copy the full SHA c43d14aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 60904da - Browse repository at this point
Copy the full SHA 60904daView commit details