Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed jump to entry from crossref #11009

Merged
merged 6 commits into from
Mar 11, 2024
Merged

Fixed jump to entry from crossref #11009

merged 6 commits into from
Mar 11, 2024

Conversation

calixtus
Copy link
Member

@calixtus calixtus commented Mar 11, 2024 •
edited by koppor
Loading

Fixes #5484

Fixes #9369

Closes #8456

Not beautiful, but works.

  • Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
  • Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

calixtus and others added 2 commits March 11, 2024 23:41
@calixtus @koppor
Simplify casts
0a4f32e 
Co-authored-by: Oliver Kopp <kopp.dev@gmail.com>
@calixtus @koppor
CHANGELOG.md
03ead34 
Co-authored-by: Oliver Kopp <kopp.dev@gmail.com>
@calixtus calixtus added ui status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers maintable entry-editor labels Mar 11, 2024
koppor
koppor previously approved these changes Mar 11, 2024
View reviewed changes
@koppor koppor enabled auto-merge March 11, 2024 22:51
@Siedlerchr
Copy link
Member

supersedes #8456

calixtus and others added 2 commits March 12, 2024 00:09
@calixtus @koppor
Add control-click
e376cd0 
Co-authored-by: Oliver Kopp <kopp.dev@gmail.com>
@calixtus
Merge remote-tracking branch 'upstream/fix-jumptocrossref' into fix-j…
6abe2ad 
…umptocrossref

# Conflicts:
#	src/main/java/org/jabref/gui/fieldeditors/FieldEditors.java
@koppor
Copy link
Member

koppor commented Mar 11, 2024

Side comment: This implements #8456 (comment)

@calixtus @koppor
Fix l10n
889137c 
Co-authored-by: Oliver Kopp <kopp.dev@gmail.com>
@koppor koppor mentioned this pull request Mar 11, 2024
Closed
8 tasks
@koppor koppor added this pull request to the merge queue Mar 11, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 11, 2024 •
edited
Loading

The build for this PR is no longer available. Please visit https://builds.jabref.org/main/ for the latest build.

Merged via the queue into main with commit a7a69db Mar 11, 2024
21 checks passed
@koppor koppor deleted the fix-jumptocrossref branch March 11, 2024 23:34
Siedlerchr added a commit to Frequinzy/jabref that referenced this pull request Mar 13, 2024
@Siedlerchr
Merge remote-tracking branch 'upstream/main' into bibdeskImport
8a4ec4e 
* upstream/main: (36 commits)
  chore: remove repetitive words (JabRef#11015)
  Fix test names (JabRef#11014)
  Remove obsolete "Comments" tab configuration (JabRef#11011)
  Fix "Other fields" tab respecting custom tabs (JabRef#11012)
  [WIP] Extract PDF References (JabRef#10437)
  Fixed jump to entry from crossref (JabRef#11009)
  fix suggestion provider for crossref field (JabRef#10962)
  Use SequencedSet for required and optional fields (JabRef#11007)
  Bump io.github.classgraph:classgraph from 4.8.165 to 4.8.168 (JabRef#11005)
  Bump org.glassfish.hk2:hk2-api from 3.0.6 to 3.1.0 (JabRef#11006)
  Bump org.apache.logging.log4j:log4j-to-slf4j from 2.23.0 to 2.23.1 (JabRef#11003)
  Bump org.javamodularity.moduleplugin from 1.8.14 to 1.8.15 (JabRef#11002)
  Bump jakarta.xml.bind:jakarta.xml.bind-api from 4.0.1 to 4.0.2 (JabRef#11004)
  Bump softprops/action-gh-release from 1 to 2 (JabRef#11000)
  Bump gittools/actions from 0.13.2 to 0.13.4 (JabRef#11001)
  Update custom-svg-icons.md (JabRef#10999)
  Update Texworks icon (JabRef#10998)
  Use tags editor for auto completion preferences (JabRef#10990)
  Enable auto merge of CHANGELOG.md (JabRef#10986)
  Enhance DOI parser to deal with special characters (JabRef#10989)
  ...

# Conflicts:
#	build.gradle
Siedlerchr added a commit that referenced this pull request Mar 17, 2024
@Siedlerchr
Merge remote-tracking branch 'upstream/main' into fix-for-issue-10872
2e88fe0 
* upstream/main: (26 commits)
  Speed up failure reporting (#11030)
  Importing of BibDesk Groups and Linked Files (#10968)
  Convert RemoveBracesFormatterTest to @ParameterizedTest (#11033)
  Update teaching.md
  Remove non-existing recipe (#11029)
  Update CSL styles (#11031)
  Clean up defintions of entry types (#11013)
  Fix log file path on Windows (#11028)
  Change to rolling logs (#11023)
  chore: remove repetitive words (#11015)
  Fix test names (#11014)
  Remove obsolete "Comments" tab configuration (#11011)
  Fix "Other fields" tab respecting custom tabs (#11012)
  [WIP] Extract PDF References (#10437)
  Fixed jump to entry from crossref (#11009)
  fix suggestion provider for crossref field (#10962)
  Use SequencedSet for required and optional fields (#11007)
  Bump io.github.classgraph:classgraph from 4.8.165 to 4.8.168 (#11005)
  Bump org.glassfish.hk2:hk2-api from 3.0.6 to 3.1.0 (#11006)
  Bump org.apache.logging.log4j:log4j-to-slf4j from 2.23.0 to 2.23.1 (#11003)
  ...

# Conflicts:
#	src/main/resources/csl-styles
Siedlerchr added a commit that referenced this pull request Mar 17, 2024
@Siedlerchr
Merge remote-tracking branch 'upstream/main' into fix-for-issue-10872
047828d 
* upstream/main: (26 commits)
  Speed up failure reporting (#11030)
  Importing of BibDesk Groups and Linked Files (#10968)
  Convert RemoveBracesFormatterTest to @ParameterizedTest (#11033)
  Update teaching.md
  Remove non-existing recipe (#11029)
  Update CSL styles (#11031)
  Clean up defintions of entry types (#11013)
  Fix log file path on Windows (#11028)
  Change to rolling logs (#11023)
  chore: remove repetitive words (#11015)
  Fix test names (#11014)
  Remove obsolete "Comments" tab configuration (#11011)
  Fix "Other fields" tab respecting custom tabs (#11012)
  [WIP] Extract PDF References (#10437)
  Fixed jump to entry from crossref (#11009)
  fix suggestion provider for crossref field (#10962)
  Use SequencedSet for required and optional fields (#11007)
  Bump io.github.classgraph:classgraph from 4.8.165 to 4.8.168 (#11005)
  Bump org.glassfish.hk2:hk2-api from 3.0.6 to 3.1.0 (#11006)
  Bump org.apache.logging.log4j:log4j-to-slf4j from 2.23.0 to 2.23.1 (#11003)
  ...

# Conflicts:
#	src/main/resources/csl-styles
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@koppor koppor koppor approved these changes

Assignees
No one assigned
Labels
entry-editor maintable status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers ui
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature request: 'jump to entry' in 'crossref' Jump to KEY does not work
3 participants
@calixtus @Siedlerchr @koppor