Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace jthemedetector with new platform prefs #11079

Merged
merged 2 commits into from
Mar 22, 2024
Merged

Replace jthemedetector with new platform prefs #11079

merged 2 commits into from
Mar 22, 2024

Conversation

calixtus
Copy link
Member

@calixtus calixtus commented Mar 22, 2024 •
edited
Loading

Refs #8729
Follow-up to #10593

  • Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
  • Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

@calixtus calixtus marked this pull request as ready for review March 22, 2024 19:02
@calixtus calixtus added ui status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers dependencies Pull requests that update a dependency file Dark Theme labels Mar 22, 2024
@Siedlerchr
Copy link
Member

Works fine on macOs 14

@Siedlerchr Siedlerchr added this pull request to the merge queue Mar 22, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 22, 2024 •
edited
Loading

The build for this PR is no longer available. Please visit https://builds.jabref.org/main/ for the latest build.

Merged via the queue into main with commit 4b957d7 Mar 22, 2024
27 of 28 checks passed
@Siedlerchr Siedlerchr deleted the replace-themedetector branch March 22, 2024 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Siedlerchr Siedlerchr Siedlerchr approved these changes

Assignees
No one assigned
Labels
Dark Theme dependencies Pull requests that update a dependency file status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers ui
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@calixtus @Siedlerchr