Fix importing of custom entry types with duplicate fields #11132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Siedlerchr
added
the
status: ready-for-review
koppor
previously approved these changes
Apr 2, 2024
|
Nice find! Review comment was #11013 (review) What we overlooked is the entry type customization by users. There should be no crash of JabRef when there is an inconsistent configuration. |
|
The build for this PR is no longer available. Please visit https://builds.jabref.org/main/ for the latest build. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11127
This is a fix for the exception introduced in #11013 (review)
The main culprit is that we did not do a migration to remove duplicate fields
Mandatory checks
CHANGELOG.mddescribed in a way that is understandable for the average user (if applicable)