Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try JavaFX hotfix #11212

Closed
wants to merge 12 commits into from
Closed

Try JavaFX hotfix #11212

wants to merge 12 commits into from

Conversation

koppor
Copy link
Member

@koppor koppor commented Apr 16, 2024

This PR is to check if the hotfix works.

  • Adds the JavaFX compiled output as binaries to the source
  • Uses the idea of the JDK-EA build workflow to use a local SDK instead of the one of maven central.

Mandatory checks

  • Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
  • Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

@koppor koppor marked this pull request as draft April 16, 2024 15:08
Copy link
Contributor

github-actions bot commented Apr 18, 2024

The build for this PR is no longer available. Please visit https://builds.jabref.org/main/ for the latest build.

@koppor
Copy link
Member Author

koppor commented Apr 18, 2024

Cannot continue. First, we need to remove git lfs

  Bandwidth: 1.54 GB / 1 GB (154%)
  Storage: 0.22 GB / 1 GB (22%)

@koppor
Copy link
Member Author

koppor commented Apr 29, 2024

Not needed any more. Does not work and eats up limited Git LFS resources.

@koppor koppor closed this Apr 29, 2024
@koppor koppor deleted the jfx-hotfix branch April 29, 2024 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant