improving UX when a http exception is encountered

[RehanChalana]

Closes #11223

1. Created SimpleHttpResponse class to simplify HTTP Response handling
2. Refactored FetcherClientException to use SimpleHttpResponse, allowing for more detailed error messages and debugging
3. replaced API keys with [REDACTED] in the error messages
4. Created SimpleHttpResponse instance from HttpURLConnection and included it in FetcherClientException
5. cached and displayed Fetcher Exception in the WebSearchPaneViewModel class with a dialogService.showErrorDialogAndWait() (including the response body of the SimpleHttpResponse)

I am aware the dialog box content and the way i am caching error needs improvement and I am seeking feedback on that or any changes that do not meet the quality of JabRef.

Can you please describe what should be the content of the (title and body) of the dialog box with this new approach of using SimpleHttpResponse object. and if the stack trace should be included in the dialog box as well

I am not sure how we can include (or we should not)both the http response and the redacted URL in the dialog box. Because they come from two different exceptions (parent and grandparent exceptions).

updated screenshot

Thank you so much for all your time and guidance

Mandatory checks

• Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
• Tests created for changes (if applicable)
• Manually tested changed features in running JabRef (always required)
• Screenshots added in PR description (for UI changes)
• Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
• Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

[calixtus]

are you sure about that? That does not seem right...

[RehanChalana]

I am sorry i am not aware when i changed the file , must have been a mistake

[calixtus]

no need to be sorry, mistakes happen and we learn. as a general rule, always check your changes before committing them. its easy if you use "git gui" to commit instead of the command line or the integrates tools in the ide.

[calixtus]

just some quick notes after skimming your changes. thank you for your interest in jabref!

[koppor]

Good initial version. I see some improvement points.

The main point is that the handling also needs to be added to org.jabref.logic.importer.EntryBasedParserFetcher#performSearch.

[RehanChalana]

Good initial version. I see some improvement points.

The main point is that the handling also needs to be added to org.jabref.logic.importer.EntryBasedParserFetcher#performSearch.

How can i reproduce the error at EntryBasedParserFetcher ?

also i think we should check and remove the api_keys from org/jabref/logic/importer/PagedSearchBasedParserFetcher#getBibEntries as well

[RehanChalana]

One issue i encountered in some fetchers

IOException is thrown at org/jabref/logic/net/URLDownload.java at int status = lConnection.getResponseCode();

Hence the resulting error is not an instance of FetcherClientException and hence api key is not removed from the error message

[koppor]

One issue i encountered in some fetchers

Can you try to work on it, too?

Maybe wrap it in Fetcher exception?

(Need to check the source for myself. Where is URL Download used etc. Maybe, one could introduce FetcherIoException subclassing IOexception and having the http response contained. Thus, one can add another catch where appropriate)

[RehanChalana]

Can you try to work on it, too?

Yes of course

I will work on it and push the changes

[RehanChalana]

One issue i encountered in some fetchers

Can you try to work on it, too?

Maybe wrap it in Fetcher exception?

(Need to check the source for myself. Where is URL Download used etc. Maybe, one could introduce FetcherIoException subclassing IOexception and having the http response contained. Thus, one can add another catch where appropriate)

I am not sure how to proceed further in this issue. The source of error seems sun/net/www/protocol/http/HttpURLConnection.java where instead of returning the status code , it is throwing IOException

Some guidance will be really helpful.

Also i would like to inform the way i am producing these errors is going to File-->preferences-->WebSearch and choosing Custom API keys for fetchers (i leave the value blank)

can this approach be causing some issues?

[koppor]

I really need to think deeper of this. Currently, I think: Can this IOException be catched early and transformed to src/main/java/org/jabref/http/dto/SimpleHttpResponse.java?

outdated