Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate DOI special character parsing test in existing parameterized test #11603

Merged
merged 3 commits into from
Aug 11, 2024

Conversation

subhramit
Copy link
Collaborator

@subhramit subhramit commented Aug 10, 2024

Follow-up to: #11084
Integrates test for the DOI URL parsing (for the case of special characters) into existing parameterized test.
Refs #11084 (comment)

Mandatory checks

  • Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
  • Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

@subhramit subhramit mentioned this pull request Aug 10, 2024
6 tasks
@subhramit subhramit requested a review from koppor August 10, 2024 16:23
@subhramit subhramit changed the title Integrate doi special character test in existing parameterized test Integrate DOI parsing special character test in existing parameterized test Aug 10, 2024
@subhramit subhramit added the type: code-quality Issues related to code or architecture decisions label Aug 10, 2024
Co-authored-by: Christoph <siedlerkiller@gmail.com>
Siedlerchr
Siedlerchr previously approved these changes Aug 11, 2024
@Siedlerchr Siedlerchr added this pull request to the merge queue Aug 11, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 11, 2024
@Siedlerchr Siedlerchr added this pull request to the merge queue Aug 11, 2024
Merged via the queue into JabRef:main with commit 6b39197 Aug 11, 2024
22 checks passed
@Siedlerchr Siedlerchr deleted the doi-todo branch August 11, 2024 16:29
@subhramit subhramit added the tests Related to tests label Aug 19, 2024
@subhramit subhramit changed the title Integrate DOI parsing special character test in existing parameterized test Integrate DOI special character parsing test in existing parameterized test Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests Related to tests type: code-quality Issues related to code or architecture decisions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants