-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade EndNote XML exporter to StAX #11665
Conversation
About RuntimeException: ModsExporter also uses StAX and works with the so called SaveException. Does this maybe help? |
It did, took some inspiration. Used |
Another prominent change - removed the transformer. |
Why? StackOverflow says different:
Benefit - even more memory efficient (for large databases) as we directly write to the output stream instead of building the unformatted xml in memory and then transforming it. Zotero does it this way too. |
@Siedlerchr I find the new code less maintainable than the old one. In both codes, we do NOT need to generate Java-classes based on some XSD file. -- I propose to use this PR as learning for Subhramit for StAX, but close the PR due to maintenance concerns (see for example the necessary comment on closing XML elements). |
Yes that seems to be odd |
DevCall: Longer discussion. We close. However, in case someone shows up with a large library and gets out of memory exceptions, we will reconsider. |
Follow-up to #11157
Upgrade EndNote XML exporter
Refs. #11157 (comment)
Note: In the existing lambdas, now
XMLStreamException
is caught and thrown asRuntimeException
as lambdas don't allow checked exceptions to be directly thrown from them.Mandatory checks
CHANGELOG.md
described in a way that is understandable for the average user (if applicable)