-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chat with groups + AI chat UI and logic overhaul #11666
Conversation
can you show some screenshots? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just first mall comments. 1k lines need more time to review
src/test/java/org/jabref/logic/ai/chathistory/BibDatabaseChatHistoryManagerTest.java
Show resolved
Hide resolved
src/main/java/org/jabref/logic/ai/chathistory/ChatHistoryService.java
Outdated
Show resolved
Hide resolved
I'm only one step towards chat with groups. The last push won't compile, just because, I need some rest :) |
Okay, now PR is working. When I finally add this group chat window I will refine the PR. (Just one step left) |
src/main/java/org/jabref/gui/ai/components/aichat/AiChatComponent.java
Outdated
Show resolved
Hide resolved
it's a general issue (I think) #11572 |
Okay, chat with groups is here. Now, the PR should be tested thoroughly and polished... |
Yay, more new code! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Your code currently does not meet JabRef's code guidelines.
We use Checkstyle to identify issues.
The tool reviewdog already placed comments on GitHub to indicate the places. See the tab "Files" in you PR.
Please carefully follow the setup guide for the codestyle.
Afterwards, please run checkstyle locally and fix the issues.
You can check review dog's comments at the tab "Files changed" of your pull request.
…dComponent.java Co-authored-by: Oliver Kopp <kopp.dev@gmail.com>
The PR's number is # 11 666 |
Changes include:
ObservableList<ChatMessage>
, so for everyBibEntry
there is a chat, and it's easy to get that chat. So chat history is separated in a facadeChatHistoryService
, that works fine while running JabRef, and an implementationChatHistoryImplementation
, implementation is responsible for loading and storing chat history.ProcessingInfo<I, O>
for easy tracking of background processes (ingestion and summarization)...Storage
) and implementation (MVStore...Storage
). For each of the implementation there are testsHow to use the new "Chat with group" feature:
New UI:
Group chat:
Notifications:
Mandatory checks
CHANGELOG.md
described in a way that is understandable for the average user (if applicable)