Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Selected SLR catalogs: maintain preferences abstraction level #11667

Merged
merged 39 commits into from
Aug 22, 2024

Conversation

subhramit
Copy link
Collaborator

@subhramit subhramit commented Aug 22, 2024

Follow-up to: #11635
Refs. #11635 (comment)

We were injecting the entire PreferenceServices here, which was unnecessary. We can abstract away and use the required workspacePreferences.

Mandatory checks

  • Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
  • Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

subhramit and others added 30 commits July 15, 2024 20:10
Co-authored-by: Christoph <siedlerkiller@gmail.com>
Co-authored-by: Christoph <siedlerkiller@gmail.com>
Co-authored-by: Christoph <siedlerkiller@gmail.com>
@subhramit subhramit added the type: code-quality Issues related to code or architecture decisions label Aug 22, 2024
@subhramit subhramit changed the title Selected SLR catalogs: Maintain preferences abstraction level Selected SLR catalogs: maintain preferences abstraction level Aug 22, 2024
@calixtus calixtus added this pull request to the merge queue Aug 22, 2024
Merged via the queue into JabRef:main with commit 4ab11ca Aug 22, 2024
22 checks passed
@calixtus calixtus deleted the slr-prefs branch August 22, 2024 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
preferences SLR type: code-quality Issues related to code or architecture decisions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants