Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update LatexCitationsTab.java #11689

Merged
merged 1 commit into from
Sep 1, 2024
Merged

Update LatexCitationsTab.java #11689

merged 1 commit into from
Sep 1, 2024

Conversation

ilippert
Copy link
Contributor

@ilippert ilippert commented Aug 31, 2024

should contribute to fixing https://github.com/JabRef/jabref-issue-melting-pot/issues/495

sorry, I did not read the guidance to code contributions - I hope this is helpful.

https://github.com/JabRef/jabref-issue-melting-pot/issues/495 provides the Screenshot to the string that I try to change with this patch.

Mandatory checks

  • Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
  • Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

@calixtus
Copy link
Member

Looks good to me, tests are green too.

Copy link
Collaborator

@LoayGhreeb LoayGhreeb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The issue was already fixed in #11602, but it's okay to update the constant value for consistency.

@Siedlerchr Siedlerchr added this pull request to the merge queue Sep 1, 2024
Merged via the queue into JabRef:main with commit 7179c71 Sep 1, 2024
22 checks passed
@ilippert ilippert deleted the patch-1 branch September 1, 2024 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants