Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ArgumentProcessor #11728

Merged
merged 6 commits into from
Sep 8, 2024
Merged

Fix ArgumentProcessor #11728

merged 6 commits into from
Sep 8, 2024

Conversation

koppor
Copy link
Member

@koppor koppor commented Sep 8, 2024

Fixes an architectural flaw

Refs #110

Mandatory checks

  • Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
  • Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

koppor and others added 5 commits September 8, 2024 11:45
Co-authored-by: Carl Christian Snethlage <50491877+calixtus@users.noreply.github.com>
Co-authored-by: Christoph <siedlerkiller@gmail.com>
Co-authored-by: Carl Christian Snethlage <50491877+calixtus@users.noreply.github.com>
@koppor koppor added the jabcon label Sep 8, 2024
@koppor koppor enabled auto-merge September 8, 2024 11:38
Siedlerchr
Siedlerchr previously approved these changes Sep 8, 2024
@koppor koppor added this pull request to the merge queue Sep 8, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 8, 2024
@koppor koppor enabled auto-merge September 8, 2024 16:17
@koppor koppor added this pull request to the merge queue Sep 8, 2024
Copy link
Contributor

github-actions bot commented Sep 8, 2024

The build for this PR is no longer available. Please visit https://builds.jabref.org/main/ for the latest build.

Merged via the queue into main with commit f49dfac Sep 8, 2024
49 checks passed
@koppor koppor deleted the fix-cross-deps branch September 8, 2024 16:35
@koppor koppor mentioned this pull request Sep 8, 2024
6 tasks
leaf-soba pushed a commit to leaf-soba/jabref that referenced this pull request Sep 11, 2024
* Refine JavaDoc

* Add TODOs

Co-authored-by: Carl Christian Snethlage <50491877+calixtus@users.noreply.github.com>

* Fix typos

* Reoder settings

* Fix arch flaw

Co-authored-by: Christoph <siedlerkiller@gmail.com>
Co-authored-by: Carl Christian Snethlage <50491877+calixtus@users.noreply.github.com>

* Fix checkstyle and formatting

---------

Co-authored-by: Carl Christian Snethlage <50491877+calixtus@users.noreply.github.com>
Co-authored-by: Christoph <siedlerkiller@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants