-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document app freeze with wrong password prompt integration. #11778
Document app freeze with wrong password prompt integration. #11778
Conversation
Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You modified Markdown (*.md
) files and did not meet JabRef's rules for consistently formatted Markdown files.
To ensure consistent styling, we have markdown-lint in place.
Markdown lint's rules help to keep our Markdown files consistent within this repository and consistent with the Markdown files outside here.
You can check the detailed error output by navigating to your pull request, selecting the tab "Checks", section "Tests" (on the left), subsection "Markdown".
@Siedlerchr I'm using IntelliJ, in which there seems to be no plugin for markdownlint. There's a ruby gem and a node package, but I'm unsure if I can run either locally against the project and have it work. |
Yeah here as well but that's why I edit the markdown stuff with VsCode |
@Siedlerchr Sensible, sensible. Apparently there's a plugin for neovim or something, I'll get that up and running at some point, but to be honest, it's kind of sad that there's no command line utility written in Rust or C or something which can perform the linting. |
You can also always use the github web vscode editor (and install the markdown-lint extension on the fly). Just press " |
What about https://github.com/Strajk/intellij-plugin-markdownlint? It is said to be slow (Strajk/intellij-plugin-markdownlint#4), but could work? |
Smalltalk: https://github.com/0xpayne/gpt-migrate on https://github.com/DavidAnson/markdownlint 🤣🤣 Note that one can use |
|
||
## Attempts to open preferences panel freezes application | ||
|
||
This is likely caused by improper integration of your OS or Desktop Environment with your password prompting program or password manager. Ensure that these are working properly, then restart your machine and attempt to run the program. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it possible to detail "Ensure that these are working properly"? Maybe, giving an example?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could detail what some of the desired states would be, ie. If everything works, a password prompt will appear as the program starts, given the keyring your OS uses hasn't already been unlocked.
The trouble is, it depends on OS what the exact implementation being used is, and therefore how to configure it will vary. I don't have Windows or MacOS personally, so I can only speak for Linux users and state that their xdg-desktop-portal
settings need to refer to active and valid portal implementations they have installed. And that may not be the whole story; my lack of knowledge means I'd need to do further research to confirm or deny that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think, even these sentences help.
What do you think of:
To clarify, in an ideal scenario, a password prompt should appear when the program starts, provided the keyring your OS uses has not already been unlocked. However, the implementation details vary depending on the operating system, which makes troubleshooting more complex.
For Windows and macOS users, specific configurations may differ based on the password management tools and settings used, so ensure your OS's password management system is properly set up and functioning.
For Linux users, ensure that your `xdg-desktop-portal` settings refer to active and valid portal implementations installed on your system. However, there might be other factors involved, so additional research or guidance specific to your distribution may be necessary.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, we can always change the description if we learn more later.
Should I reopen the issue, or just make a PR for the same issue? Or rather document the change in a new issue?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just make another PR, e.g. follow up to ###
Closes #11766
Document freezes in preferences panel resulting from improper password prompter integration on dev machine for developers.
Mandatory checks
CHANGELOG.md
described in a way that is understandable for the average user (if applicable)