Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix external-libraries.md #11810

Merged
merged 5 commits into from
Sep 23, 2024
Merged

Fix external-libraries.md #11810

merged 5 commits into from
Sep 23, 2024

Conversation

koppor
Copy link
Member

@koppor koppor commented Sep 23, 2024

First batch to fix external-libraries.md.

The new libs will come in a follow-up PR.

Mandatory checks

  • Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
  • Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 23, 2024 •
edited
Loading

The build for this PR is no longer available. Please visit https://builds.jabref.org/main/ for the latest build.

Siedlerchr
Siedlerchr reviewed Sep 23, 2024
View reviewed changes
external-libraries.md
@@ -84,6 +91,13 @@ URL: https://github.com/FasterXML/jackson
License: Apache-2.0
```

```yaml
Id: com.knuddels:jtokkit
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Knuddels? Lol! :-D

@koppor koppor added this pull request to the merge queue Sep 23, 2024
Merged via the queue into main with commit 29253a4 Sep 23, 2024
30 of 32 checks passed
@koppor koppor deleted the fix-external-libs branch September 23, 2024 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Siedlerchr Siedlerchr Siedlerchr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@koppor @Siedlerchr