Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Less toolbar spacing option #11836

Closed
wants to merge 2 commits into from
Closed

Conversation

InAnYan
Copy link
Collaborator

@InAnYan InAnYan commented Sep 26, 2024

Closes https://github.com/JabRef/jabref-issue-melting-pot/issues/561.

What do you think?

New UI:

Toolbar:
image_2024-09-26_10-51-10

Setting:
image

Old UI:
image_2024-09-26_10-49-18

Mandatory checks

- [ ] Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
- [ ] Tests created for changes (if applicable)

@koppor
Copy link
Member

koppor commented Sep 26, 2024

We really need a restart? ^^

image

@koppor
Copy link
Member

koppor commented Sep 26, 2024

We should not offer a switch for that. Either CSS skinned or find a proper default.

Proposal:

  1. Work on https://github.com/JabRef/jabref-issue-melting-pot/issues/558.
  2. Add switch "compact UI", where everything is set

Reason: For me: Too much code / preferences for a tiny change 😅

@calixtus
Copy link
Member

Can this matter be somehow transfered entierly to css? It would be great if we only had basic controls hardcoded and all the styling (i mean really all the styling options) controlled by css - which would make it really user-modifieable and less clumsy in the java sources...

@InAnYan
Copy link
Collaborator Author

InAnYan commented Sep 27, 2024

Well, yeah)

I only understood this i in the end, that we can use some CSS setting, rather this.

Closing in favour of the mentioned issue

@InAnYan InAnYan closed this Sep 27, 2024
@calixtus
Copy link
Member

Im thinking, maybe one could give the spacers a name, then they probably would be accessible from css? I'm not sure if this is possible...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants