Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve performance with duplicate check on paste #11843

Merged
merged 3 commits into from
Sep 28, 2024

Conversation

Siedlerchr
Copy link
Member

@Siedlerchr Siedlerchr commented Sep 28, 2024

Run duplicate check on background thread

In 90% cases better performance, except if you have plenty of duplicates (UI dialog is shown then)

Fixes https://github.com/JabRef/jabref-issue-melting-pot/issues/574

Side effect, UI might freeze if you copy a large number of entries because of respawning the duplicate entry dialog. Not happy about it,

Mandatory checks

  • Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
  • Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

@Siedlerchr Siedlerchr added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Sep 28, 2024
@LoayGhreeb
Copy link
Collaborator

Does this also cover import entries from web searches and "Import into current library" in the File menu?

@Siedlerchr
Copy link
Member Author

Siedlerchr commented Sep 28, 2024

Yes, should be at least for the Web search, that uses the ImportHandler, for the import into current file I am not sure

Copy link
Contributor

github-actions bot commented Sep 28, 2024

The build for this PR is no longer available. Please visit https://builds.jabref.org/main/ for the latest build.

@Siedlerchr Siedlerchr added this pull request to the merge queue Sep 28, 2024
Merged via the queue into main with commit 538f0ee Sep 28, 2024
26 of 27 checks passed
@Siedlerchr Siedlerchr deleted the performanceBackgroundThread branch September 28, 2024 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants