DOI improvements #1447
Merged
DOI improvements #1447
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stefan-kolb
added
the
status: ready-for-review
| } | ||
|
|
||
| private static double editDistanceIgnoreCase(String a, String b) { | ||
| return METRIC_DISTANCE.distance(a.toLowerCase(), b.toLowerCase()); |
There was a problem hiding this comment.
Use a locale when using toLowerCase.
|
LGTM |
| import net.sf.jabref.model.database.BibDatabase; | ||
| import net.sf.jabref.model.entry.BibEntry; | ||
|
|
||
| public class CrossrefFetcherTest { |
There was a problem hiding this comment.
Rewrite this as a real JUnit test?
There was a problem hiding this comment.
We already have tests for the Crossref fetcher. This is a "tool" to analyze the accuracy of the algorithm.
There was a problem hiding this comment.
Maybe add a short JavaDoc to describe the purpose and the usage of the tool?
There was a problem hiding this comment.
Should I remove it from the git repo?
There was a problem hiding this comment.
I don't know 😉 If it will be useful for further improvements leave it - if it has already done its part remove it.
…ent and fetch afterwards
|
Thanks for your comments 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First batch of improvements of the DOI retrieval logic.
more to come: #1424.