Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #1476 NPE when importing from SQL DB because of missing DatabaseMode #1477

Merged
merged 2 commits into from
Jun 6, 2016

Conversation

stefan-kolb
Copy link
Member

  • Use the default mode set inside the Preferences for each import from an external SQL database
  • Add new method for getting the default DB mode from the preferences
  • Use the preferences method where necessary

@stefan-kolb stefan-kolb added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Jun 6, 2016
@stefan-kolb stefan-kolb merged commit 241b336 into master Jun 6, 2016
@stefan-kolb stefan-kolb deleted the fix-1476 branch June 6, 2016 13:42
@koppor
Copy link
Member

koppor commented Jun 6, 2016

Note that the whole SQL code will be replaced by something more smooth in #1451.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants