Fix #1500: Renaming of explicit groups changes entries accordingly #1539
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tobiasdiez
added
the
status: ready-for-review
| addPreviousEntries(); | ||
| } | ||
| } | ||
| mResultingGroup = new ExplicitGroup(m_name.getText().trim(), getContext()); |
There was a problem hiding this comment.
Since you are touching that code anyway: How about refactoring the names here according to Java code conventions? m_name -> mName. What does the m stand for, btw?
|
Only minor remarks. LGTM. |
tobiasdiez
force-pushed
the
fixRenameGroup
branch
from
2e27827
to
7e1f066
Compare
| private final JCheckBox m_sgRegExp = new JCheckBox(Localization.lang("regular expression")); | ||
| private final JTextField sgSearchExpression = new JTextField(GroupDialog.TEXTFIELD_LENGTH); | ||
| private final JCheckBox sgCaseSensitive = new JCheckBox(Localization.lang("Case sensitive")); | ||
| private final JCheckBox sgRegExp = new JCheckBox(Localization.lang("regular expression")); |
There was a problem hiding this comment.
what does sg stand for?
There was a problem hiding this comment.
searchGroup, I would make an exception here for the general rule of no abbreviations since searchGroupRegualarExpressionCheckBox is a bit to big ;)
There was a problem hiding this comment.
Not convinced. As sg is not really that common. Why not searchGroupRegExCheckBox?
|
LGTM, just merge after you addressed the minor comments. |
|
LGTM 👍 |
tobiasdiez
force-pushed
the
fixRenameGroup
branch
from
8321360
to
44d69f3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also moved the code responsible for carrying over previous assignments from the gui to logic; add tests for it.