Consistent file name casing (and other localization improvements) #1629

oscargus · 2016-07-26T10:33:55Z

Solves Consistent casing of file types. Best practice? #1558
Removed a few abbreviated terms (what's, Couldn't, didn't)
More consistent casing of translation strings (SQL-related ones ignored)

stefan-kolb · 2016-07-26T13:49:57Z

src/main/java/net/sf/jabref/importer/fetcher/OAI2Fetcher.java

                    getTitle(), JOptionPane.ERROR_MESSAGE);
        } catch (SAXException e) {
            status.showMessage(
-                    Localization.lang("An SAXException occurred while parsing '%0':", url) + "\n\n" + e.getMessage(),
+                    Localization.lang("An SAX exception occurred while parsing '%0':", url) + "\n\n" + e.getMessage(),


I was thinking of that as well. Is it pronounced "sax" or "s a x"? Since the previous code stated "An" I kept it, but it is easy to change.

I'm not a native speaker but typically I'd say this has no vowel or vowel sound so it's an A.

Although you are right with the S.A.X thingy, so we can also keep it like that...

Google finds > 10.000 "a sax exception" but only 300 "an sax exception".

stefan-kolb · 2016-07-26T13:54:00Z

I'm not sure if we really need didn't, couldn't and what's but otherwise LGTM 👍

matthiasgeiger · 2016-07-26T14:07:34Z

src/main/resources/l10n/JabRef_fr.properties

@@ -12,10 +12,10 @@
 <HTML>Could_not_find_file_'%0'<BR>linked_from_entry_'%1'</HTML>=<HTML>Le_fichier_'%0'_n'a_pas_pu_être_trouvé_<BR>à_partir_du_lien_de_l'entrée_'%1'</HTML>
 <select>=<sélectionner>
 <select_word>=<entrer_le_mot-clef>
-Abbreviate_journal_names_of_the_selected_entries_(ISO_abbreviation)=Abréger_les_noms_de_journaux_des_entrées_sélectionnées_(abréviations_ISO)
-Abbreviate_journal_names_of_the_selected_entries_(MEDLINE_abbreviation)=Abréger_les_noms_de_journaux_des_entrées_sélectionnées_(abréviations_MEDLINE)
+Abbreviate_journal_names_of_the_selected_entries_(ISO_abbreviation)=Abréger_les_noms_de_journAUX_des_entrées_sélectionnées_(abréviations_ISO)


the replacement here and at a lot of other places in this file is wrong.

Please recheck the changes in this file!

Sorry... reviewed the PR commit by commit and have not seen that you already fixed this...

matthiasgeiger · 2016-07-26T14:16:17Z

Found two small flaws - otherwise this is good to go.

Just merge after fixing!

oscargus · 2016-07-26T14:49:07Z

Thanks! I only searched for strings ending with AUX to fix and quickly browsed for the other issues (which I clearly missed).

I change to "A SAX" when I'm at it.

Siedlerchr · 2016-07-26T15:30:29Z

src/main/java/net/sf/jabref/cli/ArgumentProcessor.java

@@ -438,7 +438,7 @@ private void regenerateBibtexKeys(List<ParserResult> loaded) {
                    LabelPatternUtil.makeLabel(metaData, database, entry, Globals.prefs);
                }
            } else {
-                LOGGER.info(Localization.lang("No meta data present in bibfile. Cannot regenerate BibTeX keys"));
+                LOGGER.info(Localization.lang("No meta data present in BIB_file. Cannot regenerate BibTeX keys"));


Underscore? The other examples use just BIB file

Forgotten flaw from before I started with regex search and replace.

* master: define xjc input/ouput dir (subsequent builds will be faster) (JabRef#1628) Consistent file name casing (and other localization improvements) (JabRef#1629) Builds are now stored via build-upload.jabref.org Some enhancements and cleanups related to dates (JabRef#1575) changes should be tested manually Cleanup FindFile and asssociated tests (JabRef#1596) More field names and a method (JabRef#1627) Moved, removed, and used String constants (JabRef#1618) Updated preview entries (JabRef#1606) Improved LaTeX to Unicode/HTML formatters to output more sensible values for unknown commands (JabRef#1622) Fixed JabRef#636 by using DOICheck and DOIStrip in export filters (JabRef#1624) Converted a few getField to getFieldOptional (JabRef#1625)

@comment

Move event (JabRef#1601) * Move event package to model Update dependencies: postgres 9.4.1208 -> 9.4.1209 and wiremock from 2.1.6 to 2.1.7 Added ISBN integrity checker (JabRef#1586) Added ISBN integrity checker * Extracted ISBN class Reenable errorprone (see http://errorprone.info/) Extend the OpenConsoleFeature (JabRef#1582) * Extend the OpenConsoleFeature by selection of custom terminal emulator. - Add radio selection to the AdvancedTab - Add new JabRefPreferences - Add file check and execution commands - Add localization keys * Fix localization key. * Move console selection to ExternalTab.java * Change localization entry. * Add command executor. * Fix placeholder replacement. * Fix codacy. * Update localization key. * Remove "Specify terminal emulator" option. Add GUI outputs. * Set default command for Windows. Fix localization entries. * Remove empty lines in language files. * Use lambda expressions insead of ActionListeners * Refactoring. * Update CHANGELOG.md. * Small refactorings. Move preferences (JabRef#1604) * Move preferences-related classes into separate package * Rename JabRefPreferencesFilterDialog -> PreferencesFilterDialog and move it to gui * Fix checkstyle warning Set user agent to fix 403 status error Replace getField with getFieldOptional in all of the tests and in som… (JabRef#1591) * Replace getField with getFieldOptional in all of the tests and in some more code * Some more conversions Added filter to not show selected integrity checks (JabRef#1588) * Added filter to not show selected integrity checks * Removed unused variable Some Globals.prefs injection in logic and model (JabRef#1593) * Some Globals.prefs injection in logic and model * Some more conversions and some fixes * More injections * Even more injections * Yes, even more injections * Indeed, even more injections * Probably the last injections for now * Removed unrequired dependency and fixed issue * Dropped support for selecting sub/super to equations * Added preference classes for LatexFieldFormatter and FieldContentParser * Removed some left over code * Added JournalAbbreviationPreferences * Encapsulated LatexFieldFormatterPreferences in SavePreferences * Changed getShortDescription to accept boolean argument * Removed Globals.prefs from tests and removed unused imports * Unused import * Unused import Rewrite MedlineImporter with JAXB and add nbib fields (JabRef#1479) Add test in BibEntryWriterTest for type change When clicking on a tab, the first field now has the focus (JabRef#988) * the first Field does now have focus when clicking on a tab in the entry editor * Make first field focused when selecting a tab in entry editor The field list gets the focus as soon as it is focused (JabRef#1541) Test CustomImporter (JabRef#1501) * Test CustomImporter Fixes imports Added model.entry.FieldName that contains field name constants (JabRef#1602) * Added model.entry.FieldName that contains field name constants * More constants * Renamed and added more constants * Some more fields and cleanups * Removed MedlineHandler left from merge conflicts More fields added to FieldName (JabRef#1614) * More fields added to FieldName * Some Medline fixes [WIP] Create new fetcher infrastructure (JabRef#1594) * Introduce new Fetcher interfaces * Refactor arXiv fulltext fetcher * Add query based arXiv fetcher * Reformat code * Add a few tests for the arxiv parser * Make new arXiv fetcher available * Fix small problems related to files * Fix tests * Rename interface methods * Add changelog entry * Mark old EntryFetcher interface as deprecated * Move fetcher to importer \ fetcher * Move HelpFile from gui.help to logic.help * Rename fetchers * Rename FulltextFinder * Optimize imports * Fix failing test * Ignore failing test Added LayoutFormatterPreferences (and related files) (JabRef#1608) * Added LayoutFormatterPreferences (and related files) * Rebased * Included JournalAbbreviationLoader in LayoutPreferences Added more fields and fixed some issues (JabRef#1617) Resolves JabRef#1613 Use Jabref default icon for uninstaller for now (JabRef#1616) Always use https for help files (JabRef#1615) Implemented JabRef#1345 - cleanup ISSN (JabRef#1590) * Implemented JabRef#1345 - cleanup ISSN * Fixed comments * Extracted ISSN class * Added tests for ISSN and ISBN Added DateFormatter to LayoutEntry so that it actually works... (JabRef#1619) Converted a few getField to getFieldOptional (JabRef#1625) * Converted a few getField to getFieldOptional Fixed JabRef#636 by using DOICheck and DOIStrip in export filters (JabRef#1624) Improved LaTeX to Unicode/HTML formatters to output more sensible values for unknown commands (JabRef#1622) Updated preview entries (JabRef#1606) * Updated preview entries, which return new entry Moved, removed, and used String constants (JabRef#1618) * Moved, removed, and used String constants * Some more fixes * Moved NEWLINE, made FILE_SEPARATOR public and used it * Moved NEWLINE and FILE_SEPARATOR to OS * Moved ENCODING_PREFIX and SIGNATURE * Corrected Globals in a few comments... * Apparently the localization tests find commented out text... More field names and a method (JabRef#1627) * Introduced FieldName in ArXiV * Some more field names * More field names Cleanup FindFile and asssociated tests (JabRef#1596) * Cleanup FindFile and rework it using Streams and nio methods- * Unignore test for trying on CI * Use explicit List and Set in findFiles and caller methods * Use Lazy Stream to find files changes should be tested manually Some enhancements and cleanups related to dates (JabRef#1575) * Some enhancements and cleanups related to dates * Fixed some time zone issues * Replaced SimpleDateFormat in ZipFileChooser and replaced arrays with Lists * Changed EasyDateFormat constructors * Fixed stupid mistake * Added CHANGELOG entry * Maybe tests are passing now? * Some server side print debugging... * As it should be * Tryng LocalDateTime * No time zone * Added test for Cookie * Fixed imports... * Added a third possible date format as it turns out that the server changed while developing this PR Builds are now stored via build-upload.jabref.org Consistent file name casing (and other localization improvements) (JabRef#1629) * AUX files * ZIP files * BIB files * JAR files * didn't * Couldn't what's * Consistent casing * AUX apparently is commonly used in French words... * Fixed the flawed quick-and-dirty find-and-replace failures define xjc input/ouput dir (subsequent builds will be faster) (JabRef#1628) Execute task only when input/output dir changed. Fixed a minor issue and refactored MergeEntries (JabRef#1634) * Fixed a minor issue and refactored MergeEntries * Fixed import * Added CHANGELOG entry Added LabelPatternPreferences (JabRef#1607) * Added LabelPatternPreferences * Removed static initializer More tests (JabRef#1635) * Added more tests for Cookie * Enabled some layout tests and added test for StringUtil.intValueOfWithNull * Updated a test * Split tests Updated Errorprone to 2.0.11 (JabRef#1636) * Updated Errorprone to 2.0.11 * Corrected test Keep @comment text in a bib file (JabRef#1638) * Kep @comment text in a bib file * Add test for @comment that contains regular entries Replaced some getField and fixed some bugs (JabRef#1631) * Replaced some getField and fixed some bugs * Fixed a few things * Added CHANGELOG entries * Improved equals implementation * Text book equals and hashCode Fixed JabRef#1639 (JabRef#1641) * Fixed JabRef#1639 * Removed old code Export OO/LO citations to new database (JabRef#1630) * Export OO/LO citations to new database * Fixed problem with duplicates * Added some comments * Fixed spelling in comment * Removed general Exception Unified some equals (JabRef#1640) * Unified some equals * Imported correct Objects... Fixed one more NPE which should have been fixed in JabRef#1631 (JabRef#1649) Finished method to hide visible fields and show hidden fields - Hide method done - Show method done - ToDo repaint hidden field - ToDo test class finished field repaint remove sysouts

oscargus added 7 commits July 26, 2016 11:37

AUX files

9ea7292

ZIP files

067e854

BIB files

9445648

JAR files

c14ef15

didn't

f4cab36

Couldn't what's

1dacfbf

Consistent casing

0e44319

oscargus added internationalization i18n cleanup-ops status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers labels Jul 26, 2016

AUX apparently is commonly used in French words...

a5ed109

stefan-kolb reviewed Jul 26, 2016
View reviewed changes

matthiasgeiger reviewed Jul 26, 2016
View reviewed changes

Fixed the flawed quick-and-dirty find-and-replace failures

230dd63

oscargus merged commit 0853734 into JabRef:master Jul 26, 2016

oscargus deleted the consistentfilenamecasing branch July 26, 2016 15:06

Siedlerchr reviewed Jul 26, 2016
View reviewed changes

oscargus mentioned this pull request Jul 26, 2016

Consistent casing of file types. Best practice? #1558

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Consistent file name casing (and other localization improvements) #1629

Consistent file name casing (and other localization improvements) #1629

oscargus commented Jul 26, 2016

stefan-kolb Jul 26, 2016

oscargus Jul 26, 2016

stefan-kolb Jul 26, 2016

stefan-kolb Jul 26, 2016

tobiasdiez Jul 26, 2016 •

edited

Loading

stefan-kolb commented Jul 26, 2016

matthiasgeiger Jul 26, 2016

matthiasgeiger Jul 26, 2016

matthiasgeiger commented Jul 26, 2016

oscargus commented Jul 26, 2016

Siedlerchr Jul 26, 2016

oscargus Jul 26, 2016 via email

Consistent file name casing (and other localization improvements) #1629

Consistent file name casing (and other localization improvements) #1629

Conversation

oscargus commented Jul 26, 2016

stefan-kolb Jul 26, 2016

Choose a reason for hiding this comment

oscargus Jul 26, 2016

Choose a reason for hiding this comment

stefan-kolb Jul 26, 2016

Choose a reason for hiding this comment

stefan-kolb Jul 26, 2016

Choose a reason for hiding this comment

tobiasdiez Jul 26, 2016 • edited Loading

Choose a reason for hiding this comment

stefan-kolb commented Jul 26, 2016

matthiasgeiger Jul 26, 2016

Choose a reason for hiding this comment

matthiasgeiger Jul 26, 2016

Choose a reason for hiding this comment

matthiasgeiger commented Jul 26, 2016

oscargus commented Jul 26, 2016

Siedlerchr Jul 26, 2016

Choose a reason for hiding this comment

oscargus Jul 26, 2016 via email

Choose a reason for hiding this comment

tobiasdiez Jul 26, 2016 •

edited

Loading