Special field editor for fields with entry keys #1637

oscargus · 2016-07-28T20:38:52Z

Related to JabRef#14 among others.

There are some fundamental issues with drag and drop, such as the entry in the entry editor keeps changing when selecting other entries to drag. Also, I do not really get the table to update very nicely, even though the code is to a large extent a copy of the file link editor.

One can see this as a proof of concept and maybe something to build further upon. If it wasn't for the weird behaviour of the table, I would be more positive.

Ideally we should specify one or more fields that can be used to relate entries, such as "cites" and "similar" (or something).

Change in CHANGELOG.md described
Tests created for changes
Screenshots added (for bigger UI changes)
Manually tested changed features in running JabRef

oscargus · 2016-07-28T20:46:10Z

Some comments:

~~There will be a more intelligent text in the right column. Now I just took the title. The idea is to use some layout formatter to get a nice string.~~ Now there is a slightly more intelligent text.
~~It is possible to drag entries from the main table, but hard to know for sure which entry is in the editor when dropping.~~ Disabled drag and drop as it doesn't make sense with the current select entry -> update entry editor
The key column can be edited and the right column updates appropriately.
~~No support for entries changing keys (yet, this is already an issue for e.g. the crossref field and should be solver independently).~~ Fixed in Added change listener for crossref field #1645
~~The buttons for the crossref field are wrong. I just removed two to make it look like one cannot move entries up and down (since there can only be one entry there).~~ Fixed
~~It looks like it is possible to right-click on an entry an select it in the main table, but it doesn't work (yet).~~ Fixed
~~When moving entries up and down as well as adding them, there are some weird things going on. Maybe it is needed to synchronize absolutely every access to the underlying list?~~ Fixed
The "links" tab is just something I made up in "Set up general fields". crossref (which should be a single line field as the key, btw, if this PR is not finished) and related should be treated as regular fields.

oscargus · 2016-08-16T18:59:13Z

@JabRef/developers : This can be tested at http://builds.jabref.org/entryfield/ now as it works quite well. Make sure that you show the crossref, related, and/or entryset field(s) in some tab. With this it would also make sense to start thinking about citedby/references fields as it will be easily implementable now.

oscargus · 2016-08-16T19:10:03Z

I'm having some problems getting a bibtex key auto completer to work in the table. Has anyone worked with the auto completer and knows how it works?

koppor · 2016-09-13T12:11:49Z

Can we first do something without autocompleter?

I worked with the auto completer ~5 years ago, but I have nearly forgotten anything. And it was a mess.

koppor · 2016-09-13T12:14:15Z

Is the current state that we "only" have to test and then this is good to be reviewed?

oscargus · 2016-09-13T17:16:08Z

Yes, I think that it is good to try out. Apart from the auto completer and drag-and-drop (which seems quite hard to get right since the entry editor is updated when selecting fields) this should be OK.

koppor · 2016-09-13T18:16:21Z

src/test/java/net/sf/jabref/logic/layout/format/AuthorsTest.java

@@ -129,4 +129,20 @@ public void testNoPeriod() {
        Assert.assertEquals("B C Bruce, C K von Manson and J Jumper",
                a.format("Bruce, Bob Croydon and Charles Kermit von Manson and Jumper, Jolly"));
    }
+
+    @Test


This seems to come from another issue, but we can merge it nevertheless.

…ssRef is now treated differently

koppor · 2016-09-13T19:19:27Z

Do you have time to work on the functionality a bit?

After clicking + and double clicking on Unknown entry, the editor of the bibtex key has to be focused
When double clicking the second column, nothing happens. "Select" should be executed
When pressing + and then the "go down" button, an exception is raised

Exception in thread "AWT-EventQueue-0" java.lang.IllegalArgumentException: Row index out of range
        at javax.swing.JTable.boundRow(JTable.java:2143)
        at javax.swing.JTable.setRowSelectionInterval(JTable.java:2166)
        at net.sf.jabref.gui.fieldeditors.EntryLinkListEditor.moveEntry(EntryLinkListEditor.java:343)
        at net.sf.jabref.gui.fieldeditors.EntryLinkListEditor.lambda$new$3(EntryLinkListEditor.java:124)

I have to restart JabRef to get "Other fields" shown. Steps: New database, add entry with surelynotknown = {value}, add another entry, switch back to first entry. No tab "Other fields shown". This might really be out of scope.

koppor · 2016-09-13T19:25:31Z

Autocompletion: @stefan-kolb might know something (because of #1136), but this might be too far away. @stefan-kolb We would "just" need to have an AutoCompleter for all existing bibtex keys. If this is easy possible, that would be fine.

# Conflicts: # src/main/java/net/sf/jabref/gui/entryeditor/EntryEditor.java # src/main/java/net/sf/jabref/model/entry/InternalBibtexFields.java # src/test/java/net/sf/jabref/logic/layout/format/AuthorsTest.java

tobiasdiez · 2016-09-13T22:57:03Z

BibtexKeyAutoCompleter ?

oscargus · 2016-09-14T05:43:44Z

Yes, the auto completer is there. I just cannot get it to work in a table cell...

oscargus · 2016-09-14T05:45:24Z

src/main/java/net/sf/jabref/gui/groups/TransferableEntrySelection.java

@@ -11,7 +11,7 @@

 import net.sf.jabref.model.entry.BibEntry;

-class TransferableEntrySelection implements Transferable {
+public class TransferableEntrySelection implements Transferable {


This is a heritage from when I tried to implement drag and drop. currently it is not needed.

OK for me to move forward here. I wish the nasty UI issues of #1637 (comment) can be solved.

oscargus · 2016-09-14T15:18:32Z

I removed more unused code. Added double click (and a place holder for focusing on the bibtex key field, which I do not know how to do). I couldn't trigger the error you mentioned, but noted that the last edit is not always saved properly. For example, if one selects a new entry. I do not think this happened earlier, but not sure.

oscargus added type: feature ui labels Jul 28, 2016

oscargus mentioned this pull request Jul 29, 2016

Added change listener for crossref field #1645

Merged

3 tasks

oscargus force-pushed the entryfield branch from c59dc39 to 3c2974d Compare August 16, 2016 10:07

oscargus added 3 commits August 16, 2016 18:11

Special field editor for fields with entry keys

0b4c503

Some improvements and trying to use AutoCompletion

7b4f101

Better layout of entry description

5a4ec83

oscargus force-pushed the entryfield branch 2 times, most recently from b2e1923 to 99e17cc Compare August 16, 2016 18:55

oscargus mentioned this pull request Aug 16, 2016

Links between entries JabRef/jabref-koppor#14

Open

Got things to work better now

d6006cd

oscargus force-pushed the entryfield branch from 99e17cc to d6006cd Compare August 16, 2016 19:17

koppor reviewed Sep 13, 2016
View reviewed changes

koppor added 2 commits September 13, 2016 20:54

Remove obsolete FieldExtraComponents.getCrossrefExtraComponent as cro…

7d45a61

…ssRef is now treated differently

Add initial crossref.bib

f1f2899

Merge remote-tracking branch 'origin/master' into entryfield

890e1e4

# Conflicts: # src/main/java/net/sf/jabref/gui/entryeditor/EntryEditor.java # src/main/java/net/sf/jabref/model/entry/InternalBibtexFields.java # src/test/java/net/sf/jabref/logic/layout/format/AuthorsTest.java

oscargus reviewed Sep 14, 2016
View reviewed changes

koppor mentioned this pull request Sep 14, 2016

Multiple related entries having different relationship types plk/biblatex#475

Closed

Merge branch 'master' into entryfield

c27af9b

Removed unused code and added double click selection

e041528

Removed unused code

543b6a0

koppor merged commit 67583d9 into master Sep 20, 2016

koppor deleted the entryfield branch September 20, 2016 10:24

zesaro pushed a commit to zesaro/jabref that referenced this pull request Nov 22, 2016

Special field editor for fields with entry keys (JabRef#1637)

df04d2d

koppor mentioned this pull request Dec 9, 2016

InternalBibtexFields #2353

Closed

1 task

koppor changed the title ~~[WIP] Special field editor for fields with entry keys~~ Special field editor for fields with entry keys Sep 4, 2017

koppor mentioned this pull request Sep 4, 2017

Enhance crossref support in entry editor JabRef/jabref-koppor#257

Closed

2 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Special field editor for fields with entry keys #1637

Special field editor for fields with entry keys #1637

oscargus commented Jul 28, 2016

oscargus commented Jul 28, 2016 •

edited

Loading

oscargus commented Aug 16, 2016

oscargus commented Aug 16, 2016

koppor commented Sep 13, 2016

koppor commented Sep 13, 2016

oscargus commented Sep 13, 2016

koppor Sep 13, 2016

koppor commented Sep 13, 2016 •

edited by oscargus

Loading

koppor commented Sep 13, 2016 •

edited

Loading

tobiasdiez commented Sep 13, 2016

oscargus commented Sep 14, 2016

oscargus Sep 14, 2016

koppor Sep 14, 2016

oscargus commented Sep 14, 2016

Special field editor for fields with entry keys #1637

Special field editor for fields with entry keys #1637

Conversation

oscargus commented Jul 28, 2016

oscargus commented Jul 28, 2016 • edited Loading

oscargus commented Aug 16, 2016

oscargus commented Aug 16, 2016

koppor commented Sep 13, 2016

koppor commented Sep 13, 2016

oscargus commented Sep 13, 2016

koppor Sep 13, 2016

Choose a reason for hiding this comment

koppor commented Sep 13, 2016 • edited by oscargus Loading

koppor commented Sep 13, 2016 • edited Loading

tobiasdiez commented Sep 13, 2016

oscargus commented Sep 14, 2016

oscargus Sep 14, 2016

Choose a reason for hiding this comment

koppor Sep 14, 2016

Choose a reason for hiding this comment

oscargus commented Sep 14, 2016

oscargus commented Jul 28, 2016 •

edited

Loading

koppor commented Sep 13, 2016 •

edited by oscargus

Loading

koppor commented Sep 13, 2016 •

edited

Loading