Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Somefixes #1710

Merged
merged 3 commits into from
Aug 10, 2016
Merged

Somefixes #1710

merged 3 commits into from
Aug 10, 2016

Conversation

oscargus
Copy link
Contributor

  • Fixed NullPointerException when clicking OK without specifying a field name in set/clear/rename fields
  • Fixed IndexOutOfBoundsException when trying to download a full text document without selecting an entry
  • Fixed NullPointerException when trying to set a special field or mark an entry through the menu without having an open database

The changes can be reviewed one commit at a time.

  • Change in CHANGELOG.md described
  • Manually tested changed features in running JabRef
  • Check documentation status (Issue created for outdated help page at help.jabref.org?)

@oscargus oscargus added bug Confirmed bugs or reports that are very likely to be bugs status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers labels Aug 10, 2016
@@ -321,6 +329,9 @@ private static UndoableEdit massRenameField(Collection<BibEntry> entries, String
}

private static String[] getFieldNames(String s) {
if (s == null) {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will remove this once I rebase because of the translation conflicts as it is not needed...

@stefan-kolb
Copy link
Member

LGTM 👍

@koppor
Copy link
Member

koppor commented Aug 10, 2016

LGTM2, plz resolve conflicts and merge.

… an entry through the menu without having an open database
@oscargus oscargus merged commit 787d071 into JabRef:master Aug 10, 2016
@oscargus oscargus deleted the somefixes branch August 10, 2016 22:13
@oscargus oscargus mentioned this pull request Aug 11, 2016
ayanai1 pushed a commit to ayanai1/jabref that referenced this pull request Sep 5, 2016
* Fixed NPE when clicking OK without specifying a field name in set/clear/rename fields

* Fixed IndexOutOfBoundsException when trying to download a full text document without selecting an entry

* Fixed NullPointerException when trying to set a special field or mark an entry through the menu without having an open database
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Confirmed bugs or reports that are very likely to be bugs status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants