-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Somefixes #1710
Merged
Merged
Somefixes #1710
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oscargus
added
bug
Confirmed bugs or reports that are very likely to be bugs
status: ready-for-review
Pull Requests that are ready to be reviewed by the maintainers
labels
Aug 10, 2016
@@ -321,6 +329,9 @@ private static UndoableEdit massRenameField(Collection<BibEntry> entries, String | |||
} | |||
|
|||
private static String[] getFieldNames(String s) { | |||
if (s == null) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will remove this once I rebase because of the translation conflicts as it is not needed...
LGTM 👍 |
LGTM2, plz resolve conflicts and merge. |
…ocument without selecting an entry
… an entry through the menu without having an open database
Merged
ayanai1
pushed a commit
to ayanai1/jabref
that referenced
this pull request
Sep 5, 2016
* Fixed NPE when clicking OK without specifying a field name in set/clear/rename fields * Fixed IndexOutOfBoundsException when trying to download a full text document without selecting an entry * Fixed NullPointerException when trying to set a special field or mark an entry through the menu without having an open database
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug
Confirmed bugs or reports that are very likely to be bugs
status: ready-for-review
Pull Requests that are ready to be reviewed by the maintainers
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changes can be reviewed one commit at a time.