Importer now use FileExtensions enum, too, FileDialogs display extension #1737
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Siedlerchr
added
status: ready-for-review
| JSTYLE(Localization.lang("Style file"), "jstyle"), | ||
| LAYOUT(Localization.lang("Custom layout file"), "layout"), | ||
| TERMS(Localization.lang("Protected terms file"), "terms"), | ||
| TXT(Localization.lang("%0 file", Localization.lang("plain text")), "txt"), |
There was a problem hiding this comment.
There is already an old translation string for "plain text", right? If not, "Plain text" would be preferred.
There was a problem hiding this comment.
Or maybe even go for "Plain text file" now that I read the whole line of code. :-)
There was a problem hiding this comment.
Ah I just noticed, we have already both cases of Plain text in the translations.
|
Looks good to me! Some minor comments, but nothing crucial (and I guess Checkstyle will sort one of them out :-)). |
Siedlerchr
force-pushed
the
importextension
branch
from
fd6bc2d
to
0c17af0
Compare
Grouped Importer in FileExtension Created test for FileExtions
…ailing Plain text with uppercase P Importer now use FileExtensions enum, too Grouped Importer in FileExtension Created test for FileExtions
Siedlerchr
force-pushed
the
importextension
branch
from
00d7b9f
to
eca9cd8
Compare
|
Anything else, otherwise I would merge it in. (Codacy probably failed because I rebased/squashed some things) |
ayanai1
pushed a commit
to ayanai1/jabref
that referenced
this pull request
Sep 5, 2016
…ion (JabRef#1737) * Importer now use FileExtensions enum, too Grouped Importer in FileExtension Created test for FileExtions * Move FileExtensions to logic.util to prevent architecture test from failing Plain text with uppercase P Importer now use FileExtensions enum, too Grouped Importer in FileExtension Created test for FileExtions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Grouped Importer in FileExtension
Created test for FileExtensions
File Dialogs now display description and extension
(internal change)