Some OS didn't show directories when a file type was selected in the import dialog #1775
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stefan-kolb
added
the
status: ready-for-review
| @@ -43,7 +43,7 @@ public ImportFormat getImportFormat() { | |||
|
|
|||
| @Override | |||
| public boolean accept(File file) { | |||
| return filextFilter.accept(file); | |||
| return file.isDirectory() || filextFilter.accept(file); | |||
There was a problem hiding this comment.
Maybe also add if (file == null) return false;
|
LGTM 👍 |
| @@ -72,7 +72,7 @@ We refer to [GitHub issues](https://github.com/JabRef/jabref/issues) by using `# | |||
| - Fixed [#1716](https://github.com/JabRef/jabref/issues/1716): `@`-Symbols stored in BibTeX fields no longer break the database | |||
| - Fixed [#1499](https://github.com/JabRef/jabref/issues/1499): {} braces are now treated correctly in in author/editor | |||
| - Fixed [#1531](https://github.com/JabRef/jabref/issues/1531): `\relax` can be used for abbreviation of author names | |||
|
|
|||
There was a problem hiding this comment.
Did this show up in the development version (like a few hours ago ;-))? In that case I think we should skip the ChangeLog entry. Great job though!
There was a problem hiding this comment.
Must be dev version only, related to the restructuring of the Dialogues which came with #1336
There was a problem hiding this comment.
I thought so. Well, it is not entirely consistent (there are similar
entries in the current development section of the ChangeLog), so more for
next time.
(I'm thinking that maybe someone should traverse the ChangeLog and sort
issues at some stage. Then one can rephrase some entries, which are just
copies of the issue, I've done that, and possibly remove "doubtful" entries
like this. Hard to always know and keep track of though.)
There was a problem hiding this comment.
Removed the ChangeLog entry.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When importing a file (
Import into new | current Database) and a file type was selected sometimes the directories weren't shown anymore (we experienced it under win10 and linux).Furthermore BibTeXml can also be in .xml format.