Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error setting field freeze #1863

Merged
merged 9 commits into from
Aug 27, 2016
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ We refer to [GitHub issues](https://github.com/JabRef/jabref/issues) by using `#

### Fixed
- Fixed NullPointerException when opening search result window for an untitled database
- Fixed #1757: Crash after saving illegal argument in entry editor

### Removed
- The non-supported feature of being able to define file directories for any extension is removed. Still, it should work for older databases using the legacy `ps` and `pdf` fields, although we strongly encourage using the `file` field.
Expand Down
8 changes: 5 additions & 3 deletions src/main/java/net/sf/jabref/gui/entryeditor/EntryEditor.java
Original file line number Diff line number Diff line change
Expand Up @@ -1208,10 +1208,12 @@ public void actionPerformed(ActionEvent event) {
updateSource();
panel.markBaseChanged();
} catch (IllegalArgumentException ex) {
JOptionPane.showMessageDialog(frame, Localization.lang("Error") + ": " + ex.getMessage(),
Localization.lang("Error setting field"), JOptionPane.ERROR_MESSAGE);
fieldEditor.setInvalidBackgroundColor();
LOGGER.debug("Error setting field", ex);
if (!SwingUtilities.isEventDispatchThread()) {
JOptionPane.showMessageDialog(frame, Localization.lang("Error") + ": " + ex.getMessage(),
Localization.lang("Error setting field"), JOptionPane.ERROR_MESSAGE);
LOGGER.debug("Error setting field", ex);
}
}
} else {
// set == false
Expand Down