Unnecessary other field tab #2002
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Siedlerchr
added
the
status: ready-for-review
|
I have tested your PR with the help of the description in #1996 and everything works as desired. There is only one thing missing in this PR: Please add a Changelog entry and reference the issue that you fixed :) It seems somewhat counter-intuitive that explicitly adding the optional fields makes the "other fields" tab disappear, but well... it's JabRef. |
Siedlerchr
approved these changes
Sep 19, 2016
|
Thanks for your contribution! |
This was referenced Sep 25, 2016
Merged
Siedlerchr
pushed a commit
that referenced
this pull request
Sep 26, 2016
Fixes regression from #2002
zesaro
pushed a commit
to zesaro/jabref
that referenced
this pull request
Nov 22, 2016
* Optional fields list filled * CHANGELOG.md
zesaro
pushed a commit
to zesaro/jabref
that referenced
this pull request
Nov 22, 2016
Fixes regression from JabRef#2002
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switching Bibtex/Biblatex mode causes an unnecessary "other field" tab #1996, filled with optional fields, in entry editor. Other fields are defined as fields that are not required fields + optional fields. The bug is, that on switching database mode the wrong optional fields list is filled. This is fixed.