-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert deprecation #2023
Revert deprecation #2023
Conversation
…1913)" This reverts commit a9eb978. # Conflicts: # src/main/java/net/sf/jabref/logic/importer/fileformat/PdfContentImporter.java # src/main/java/net/sf/jabref/model/database/BibDatabase.java # src/main/java/net/sf/jabref/model/entry/BibEntry.java # src/test/java/net/sf/jabref/logic/search/DatabaseSearcherTest.java
The insertEntryWithDuplicationCheck vs insertEntry can be reverted. That was my bad not to recognize that "checkDuplicaiton" also changes the bibtex key (we should rename the method!). As for reverting the other changes, I put my veto in. Moving getResolvedField to the entry was just a refactoring without any negative side-effects (that I'm aware of). And I already commented why the static fields in BibEntry should be private: they are implementation details! |
As I noted in the other issue, the problem with the static fields is that |
Yes I know, if I would have an easy solution for this case, then I already could have implemented it and there would be no need to mark it as deprecated. Again, deprecated does not mean that it is forbidden to be used and that we have to remove it immediately but it signals "hey deer (sic!) developer, please think twice about using this method. We try to remove it but right now are not able to. Please don't make it harder for us by adding yet another use case. But go ahead if there is no other solution.". |
OK, guys. Regarding some comments at #1913 (comment), I currently cannot really judge what's the best way. I had some personal discussions and thus, I merge this in and we should discuss in the devcall how to proceed. |
…abRef#1913)" (JabRef#2023) This reverts commit a9eb978. # Conflicts: # src/main/java/net/sf/jabref/logic/importer/fileformat/PdfContentImporter.java # src/main/java/net/sf/jabref/model/database/BibDatabase.java # src/main/java/net/sf/jabref/model/entry/BibEntry.java # src/test/java/net/sf/jabref/logic/search/DatabaseSearcherTest.java
Following the discussion at #1913, that PR should be reverted.
This PR reverts the
@Deprecations
, but tries to keep the other improvements.I'm not sure whether
BibEntry.getResolvedField
should be kept.