Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix: NPE in the main table #2158

Merged
merged 1 commit into from
Oct 12, 2016
Merged

Hotfix: NPE in the main table #2158

merged 1 commit into from
Oct 12, 2016

Conversation

chriba
Copy link
Contributor

@chriba chriba commented Oct 12, 2016

Steps to Reproduce

  1. Create new database (or use an existing one, the important part is that the editor was never opened in this database before)
  2. create a new entry

@tschechlovdev tschechlovdev added stupro status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers labels Oct 12, 2016
@Siedlerchr
Copy link
Member

Can't reproduce that here (with an older dev version) But the code looks okay.

@tobiasdiez
Copy link
Member

LGTM

@tobiasdiez tobiasdiez merged commit 57027c0 into JabRef:master Oct 12, 2016
@chriba chriba deleted the hotfixNpeMainTable branch October 12, 2016 19:13
Siedlerchr added a commit that referenced this pull request Oct 13, 2016
* upstream/master: (24 commits)
  hotfix NPE in the main table (#2158)
  Enhance side pane toggle (#1605)
  Added gray background text to authors field to assist newcomers (#2147)
  Rewrite google scholar fetcher to new infrastructure (#2101)
  Found entries will be shown when dropping a pdf with xmp meta data (#2150)
  Japanese translation (#2155)
  Add shortcuts to context menu (#2131)
  [WIP] Doi resolution ignore (#2154)
  Fix DuplicationChecker and key generator (#2151)
  just close popup on first ESC
  keep entry in sight
  Fix isSharedDatabaseAlreadyPresent check.
  don't change entry after search if editing an entry (#2129)
  Change download URL to downloads.jabref.org (#2145)
  fix switching edited textfield in the entry editor with TAB (#2138)
  Update me.champeau.gradle.jmh' version from 0.3.0 to 0.3.1
  Update install4j plugin from 6.1.2 to 6.1.3
  Remove gradle plugin com.github.youribonnaffe.gradle.format as it is deprecated and the config uses a non-existing file
  Update gradle from 3.0 to 3.1
  Fix changing the font size not working when importing preferences (#2069)
  ...

# Conflicts:
#	src/main/java/net/sf/jabref/gui/externalfiles/DroppedFileHandler.java
#	src/main/java/net/sf/jabref/gui/importer/fetcher/GoogleScholarFetcher.java
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants