Follow up for #1323 Batch Fulltext downloader #2344
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…x some related UI issues
stefan-kolb
added
the
status: ready-for-review
| @@ -41,12 +41,26 @@ public FindFullTextAction(BasePanel basePanel) { | |||
|
|
|||
| @Override | |||
| public void init() throws Exception { | |||
| if (basePanel.getSelectedEntries().size() == 0) { | |||
There was a problem hiding this comment.
Wouldn't be a better approach to disable the menu item (as it is already done for various other actions)?
If selection size() is == 0 at this point you can just throw an exception.
There was a problem hiding this comment.
Not 100 % sure about this, but done.
3 tasks
koppor
reviewed
Dec 8, 2016
| @@ -1591,6 +1594,9 @@ public void updateEnabledState() { | |||
|
|
|||
| boolean twoEntriesSelected = current.getSelectedEntries().size() == 2; | |||
| setEnabled(twoEntriesOnlyActions, twoEntriesSelected); | |||
|
|
|||
| boolean oneOrMoreEntriesSelected = current.getSelectedEntries().size() >= 1; | |||
koppor
reviewed
Dec 8, 2016
| Localization.lang("No entry selected"), | ||
| JOptionPane.ERROR_MESSAGE); | ||
| return; | ||
| if (basePanel.getSelectedEntries().size() > 0) { |
There was a problem hiding this comment.
!isEmpty(), maybe add a logger.DEBUG statement?
koppor
approved these changes
Dec 8, 2016
tobiasdiez
pushed a commit
to tobiasdiez/jabref
that referenced
this pull request
Dec 10, 2016
* Rename menu item to plural for finding full texts * Fix layout of file dialog and increase size of file path significantly * Reuse description as tooltip, old tooltip is not really accurate anymore
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
old:
new:
