Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add scroll bars to preference dialog #2638

Merged
merged 2 commits into from
Mar 14, 2017
Merged

Add scroll bars to preference dialog #2638

merged 2 commits into from
Mar 14, 2017

Conversation

ohuang12
Copy link
Contributor

Fix for issue #2559.
Shows horizontal and vertical scroll bars when the content in the preference dialog gets too big.

  • Change in CHANGELOG.md described
  • Tests created for changes
  • Screenshots added (for bigger UI changes)
  • Manually tested changed features in running JabRef
  • Check documentation status (Issue created for outdated help page at help.jabref.org?)
  • If you changed the localization: Did you run gradle localizationUpdate?

@tobiasdiez tobiasdiez added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Mar 12, 2017
LinusDietz
LinusDietz approved these changes Mar 12, 2017
View reviewed changes
Copy link
Member

@LinusDietz LinusDietz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Siedlerchr
Copy link
Member

LGTM, If you please fix the conflict in the changelog we can merge this in.

@ohuang12
Copy link
Contributor Author

The changelog conflict should be resolved now! 😄

@Siedlerchr Siedlerchr merged commit e41c1f2 into JabRef:master Mar 14, 2017
@Siedlerchr Siedlerchr mentioned this pull request Mar 15, 2017
Closed
@RolfStarre RolfStarre deleted the resizePreferenceDialog branch March 17, 2017 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LinusDietz LinusDietz LinusDietz approved these changes

@Siedlerchr Siedlerchr Siedlerchr approved these changes

Assignees
No one assigned
Labels
status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ohuang12 @Siedlerchr @LinusDietz @tobiasdiez