Improve issue reporting a bit #2641
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stefan-kolb
added
the
status: ready-for-review
tobiasdiez
approved these changes
Mar 13, 2017
|
@tobiasdiez Actually it is not the restriction of the URL which is quite high (over 2000 i think), but the call from the command line, e.g., explorer.exe "https://www....". Seems like the explorer does not take such a long argument. |
Siedlerchr
approved these changes
Mar 14, 2017
|
From my point of view looks good. Will merge it in now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #2573.
I also wanted to add the log details to the report without the necessity to paste them later on. Dunno why this was implemented this way initially (See #1383). However, the explorer will cut off the arguments at some point so this did not work for me.
I think it is not convenient if the user needs to add this info manually.
Maybe someone else has an idea how to change this.
I still think the current addition fixes #2573 for now.