Add test for ordinals #2752
Add test for ordinals #2752
Conversation
|
I have fixed the ordinals, with the side-effect that e.g., italics are now also converted into unicode. What do you think about that? |
|
Refs #160 I think, I begin to like it, because the display of JabRef in the UI will improve. As stated in #2601 (comment), I will step away from biblatex in papers and so, we can move on here. |
|
As indicated in #2784, this breaks support for italics in the main table, which was working before. We should revert it and find another way to support ordinals. |
|
Hi @lenhard, the problem is you always loose something. I have made this handy chart of the four options and what works when (on my linux system).
In conclusion I would suggest to investigate what factors influence the bug that so far was only seen on @AEgit's system. |
|
@lynyus : Let me know which additional configuration details are needed. I still encounter the bug in: |
|
@AEgit the problem is: I have no idea what could help us :/ |
|
One solution might be to convert italics back into regular ascii after the latex2unicode conversion? |
|
Hmmm, ok - am I really the only one with a Windows system, who encounters this problem? Because if that's the case, it might be my/my system's fault. But as far as I can tell @Siedlerchr confirmed the issue on his Windows 10 installation (#2784). Therefore it sounds like a Windows issue. What about the Mac users? |
|
Okay, I'm on my Windows now and I have these problems. Somehow I must have overread @Siedlerchr's comment or misinterpreted it :/ All the time I was assuming that I had checked it successfully on my windows machine. Mea culpa, I'll be working on a fix now. |
|
No worries, and thank you for your help! |
|
@lynyus Nice table, thanks for the overview :) Sure, NKC is the right option here. The problem is that we're using a Swing table as maintable and as far as I've found it just refuses to work with unicode italics (unless you have appropriate fonts installed in your system, but thats not the default). The best solution would be to get rid of the maintable in our move to JavaFX. Let's do that in the future, but let's not do it right now, because we should rather build a stable entry editor. I'll suggest something different: @AEgit How important is it really that the text in the main table is in italics? Would it be acceptable if the text would just be displayed as plain text? Because in that case, we could just eliminate the |
|
@lenhard To be honest, I'm not really bothered by the fact that the text in the main table is not in italics. As long as the entry preview shows it in italics (which it currently does), I'm pretty happy with it. Having the proper format in the main table as well, would be nice, but it is not a show-stopper for me at the moment. |
|
I have a PR now on this: #3008 |
This is a follow up for #2596 and #2601. I'd like to test how I can reproduce the behavior of ordinals.
Can someone explain me, why I don't get Unicode as result here?