Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not log an exception if side pane was not found #2791

Merged
merged 1 commit into from
Apr 24, 2017

Conversation

tobiasdiez
Copy link
Member

Some older versions had different names for the side pane components and their preferred sizes are still associated with these old names. Thus opening a newer JabRef always logged some errors, which only can be resolved by resetting the preferences.
This PR changes the log level from error to debug since I don't think that the size of a side pane is that essential.

  • Change in CHANGELOG.md described
  • Tests created for changes
  • Screenshots added (for bigger UI changes)
  • Manually tested changed features in running JabRef
  • Check documentation status (Issue created for outdated help page at help.jabref.org?)
  • If you changed the localization: Did you run gradle localizationUpdate?

Some older versions had different names for the side pane components and their preferred sizes are still associated with these old names. Thus opening a newer JabRef always logged some errors, which only can be resolved by resetting the preferences. 
This PR changes the log level from error to debug since I don't think that the size of a side pane is that essential.
@tobiasdiez tobiasdiez added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Apr 24, 2017
@Siedlerchr Siedlerchr merged commit 4e25cc6 into master Apr 24, 2017
@Siedlerchr Siedlerchr deleted the noExceptionWhenSidepaneNotFound branch April 24, 2017 16:29
Siedlerchr added a commit that referenced this pull request Apr 25, 2017
* upstream/master:
  Do not log an exception if side pane was not found (#2791)
  Added 'Ink' to the supported FileAnnotationType (required to close #2777)
  Renamed parseFileAnnotationType() to parse()
  Fixes handling of unknown PDAnnotation types.
Siedlerchr added a commit that referenced this pull request Apr 29, 2017
* upstream/master: (84 commits)
  Update README.md
  Update CHANGELOG.md
  Fixes #2789 Add Referer to API call (#2794)
  Change some FileDialogs to DialogService (#2767)
  Fix for issue 2762: Change CSV export to separate all names using semicolon (#2793)
  Set eclipse line wrapping to maximum
  Do not log an exception if side pane was not found (#2791)
  Added 'Ink' to the supported FileAnnotationType (required to close #2777)
  Renamed parseFileAnnotationType() to parse()
  Reimplement date editor in JavaFX (#2781)
  Update CONTRIBUTING.md
  Add new author
  Fixes handling of unknown PDAnnotation types.
  Update Checkstyle Version
  fix some more checkstyle warnings
  fix some more checkstyle warnings
  Fix Build failure, hopefully
  Spanish translation (#2773)
  Fixes #2766 If file is not found annotations might be null
  Fix language tests
  ...

# Conflicts:
#	src/main/java/org/jabref/logic/util/io/FileUtil.java
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants