Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOAJ search #287

Merged
merged 11 commits into from
Nov 10, 2015
Merged

DOAJ search #287

merged 11 commits into from
Nov 10, 2015

Conversation

oscargus
Copy link
Contributor

@oscargus oscargus commented Nov 3, 2015

Search for Directory of Open Access Journals. Quite functional, but the remaining things should (probably) be done

  • Help page
  • Decide on where the BibJSONConverter class should be positioned (input?)
  • More fields? ISSN?
  • Better/more error checking
  • Handle search results with more than 100 entries properly
  • Fill empty methods in DOAJFetcher
  • Update status bar
  • Add test for BibJSONConverter
  • Enable stopping search

Implements what is discussed in #208

@oscargus oscargus force-pushed the doajsearch branch 4 times, most recently from 6552efe to 9b392b1 Compare November 4, 2015 08:15
<body>
<h1>Fetching entries from DOAJ</h1>

<p><a href="http://www.diva-portal.org/">DOAJ (Directory of Open Access Journals)</a> is a database
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wrong link? 😯

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bah! Copy-paste-programming should be more automated. ;-)

@oscargus
Copy link
Contributor Author

oscargus commented Nov 8, 2015

I think I'm done there. :-)

@oscargus oscargus changed the title [WIP] DOAJ search DOAJ search Nov 8, 2015
String[] singleFieldStrings = new String[] {"year", "title", "abstract", "month"};

// Fields that are accessible in the journal part of the BibJson object
String[] journalSingleFieldStrings = new String[] {"publisher", "number", "volume"};
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can just write

String[] journalSingleFieldStrings = {"publisher", "number", "volume"};

instead of

String[] journalSingleFieldStrings = new String[] {"publisher", "number", "volume"};

@simonharrer
Copy link
Contributor

Looks good to me.

@matthiasgeiger
Copy link
Member

One minor thing: The current title is "DOAJ (Directory of Open Source Journals)" which is much longer than the rest of the fetcher titles. This introduces horizontal scrollbars in the fetcher sidebar when using the default width:

doaj-screenshot

Apart from this, "ready to go" from my side, too.

@koppor
Copy link
Member

koppor commented Nov 9, 2015

There is no such property like text-overflow in SWING, is it? 🌟

@matthiasgeiger
Copy link
Member

I think Java actually does snip too long texts - if the component has a fixed size. So this does not help here.

I'll merge the current state, but a potential improvement would be to define tooltips for the combobox to show some hints what the various abbreviations actually mean...

matthiasgeiger added a commit that referenced this pull request Nov 10, 2015
@matthiasgeiger matthiasgeiger merged commit 489d513 into JabRef:master Nov 10, 2015
@oscargus oscargus deleted the doajsearch branch November 10, 2015 07:59
@oscargus oscargus mentioned this pull request Nov 10, 2015
koppor pushed a commit that referenced this pull request Aug 1, 2023
8bbac89b21 Update locales-ca-AD.xml (#287)

git-subtree-dir: buildres/csl/csl-locales
git-subtree-split: 8bbac89b216f551ca3d4f77860818938d678badd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants