Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix importing preferences after resetting without restarting #3065

Merged
merged 2 commits into from
Aug 2, 2017

Conversation

Siedlerchr
Copy link
Member

@Siedlerchr Siedlerchr commented Aug 1, 2017

Set default Prefs to USER_HOME instead of working dir which could not have been intialized
Fix for #3064

A rare case: When you did not restart JabRef after resetting the prefs, but directly imported them, the EXPORT_Path pref returned the key for WORKING_DIRECTORY - and in that case, the String "workingDirectory" which is a non existing directory and led to an NPE in File exists

  • Change in CHANGELOG.md described
  • Tests created for changes
  • Screenshots added (for bigger UI changes)
  • Manually tested changed features in running JabRef
  • Check documentation status (Issue created for outdated help page at help.jabref.org?)
  • If you changed the localization: Did you run gradle localizationUpdate?

Set default Prefs to USER_HOME instead of working dir which could not have been intialized
@Siedlerchr Siedlerchr requested a review from stefan-kolb August 1, 2017 11:14
@Siedlerchr Siedlerchr added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Aug 1, 2017
@Siedlerchr Siedlerchr requested a review from lenhard August 1, 2017 11:34
Copy link
Member

@lenhard lenhard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested it locally and it works. And you even wrote a test for it. Excellent :)

@Siedlerchr Siedlerchr merged commit 63414b0 into master Aug 2, 2017
@Siedlerchr Siedlerchr deleted the fixFileDlgImport branch August 2, 2017 08:51
Siedlerchr added a commit that referenced this pull request Aug 6, 2017
* upstream/master:
  Add warning message if group with same name is already present (#3077)
  Fix #3062: Ctrl + F works again
  Fix del/copy/paste key trigger main table action in search bar (#3070)
  Fix markdown
  Update gradle from 4.0.1 to 4.0.2
  Fix #3045 Update Transformer plugin
  Reimplement MappedList using a backigList (#3069)
  Fix importing preferences after resetting without restarting (#3065)
  Fix some spotbugs issues (#3060)
  Import dialog when fetch (#3025)
  Adapt CircleCI build
  Adapt CI script
  Closes #3027 and updates install4j to v7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants