JavaFX FileAnnotationTab #3082
Merged
JavaFX FileAnnotationTab #3082
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Siedlerchr
reviewed
Aug 7, 2017
|
|
||
| import static org.jabref.model.pdf.FileAnnotationType.NONE; | ||
|
|
||
| public class FxFileAnnotationTab extends EntryEditorTab { |
There was a problem hiding this comment.
Why don't you use the Scence Builder to create your fxml?
http://gluonhq.com/open-source/scene-builder/
tobiasdiez
force-pushed
the
javafx-fileannotationtab
branch
from
8c35f03
to
3156930
Compare
…avafx-fileannotationtab # Conflicts: # src/main/java/org/jabref/gui/entryeditor/FileAnnotationListCellRenderer.java # src/main/java/org/jabref/gui/entryeditor/FxFileAnnotationTab.java
…avafx-fileannotationtab
|
So, I just added the final touch. Here it how it looks now: (no idea why the "Author" label is positioned at the bottom of the row...if somebody wants to try he or she is invited to fix that.) |
tobiasdiez
added
status: ready-for-review
|
I've tried out the PR and found a number of functional issues that need to be addressed before we can merge this:
|
|
I fixed one exception, however, the other is a classical NPE, because the ObjectProperty returns null, because it is not intialized. You should either define an empty File Annotation or disable the copy dialog @lynyus |
|
@JabRef/developers Please have a look if this PR is ready to be merged. |
Siedlerchr
reviewed
Aug 14, 2017
| } | ||
|
|
||
| private FileAnnotationViewModel getCurrentAnnotation() { | ||
| //TODO: It has to be initialized! NPE |
There was a problem hiding this comment.
remove comment if it is resolved
Siedlerchr
approved these changes
Aug 14, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have created an initial port of the FileAnnotationTab. It is not done yet, as I am not so proficient in GUI programming.
Fixes #2922
Fixes #3059