Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #3034: Make font size in entry editor and group panel customizable #3083

Merged
merged 1 commit into from
Aug 8, 2017
Merged

Fix #3034: Make font size in entry editor and group panel customizable #3083

merged 1 commit into from
Aug 8, 2017

Conversation

tobiasdiez
Copy link
Member

This fix for #3034 is inspired and based on #3042. Due to my limited git knowledge I was not able to directly hijack the other PR; sorry @lenhard.

  • Change in CHANGELOG.md described
  • Tests created for changes
  • Screenshots added (for bigger UI changes)
  • Manually tested changed features in running JabRef
  • Check documentation status (Issue created for outdated help page at help.jabref.org?)
  • If you changed the localization: Did you run gradle localizationUpdate?

@tobiasdiez tobiasdiez added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Aug 8, 2017
lenhard
lenhard approved these changes Aug 8, 2017
View reviewed changes
Copy link
Member

@lenhard lenhard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No problem :) A new PR is certainly way easier than repairing the things I've tried in the old one. And so concise, good job! As I can see, it even works for the groups.

I've tested the PR locally and font sizes in the entry editor scale as desired. The only place where it doesn't seem to work is the File annotations tab, but that tab is Swing and needs serious rework anyway. It shouldn't be covered in this PR.

This is a big step towards a Hi-Res display JabRef.

@tobiasdiez tobiasdiez merged commit 3acd1f8 into master Aug 8, 2017
@tobiasdiez tobiasdiez deleted the editorFontSize branch August 8, 2017 12:52
Siedlerchr added a commit that referenced this pull request Aug 9, 2017
@Siedlerchr
Merge remote-tracking branch 'upstream/master' into fixAttachFile
24cbdd1 
* upstream/master:
  Fix #3034: Make font size in entry editor and group panel customizable (#3083)
  Only load the telementry service as a background task if used (#3085)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lenhard lenhard lenhard approved these changes

Assignees
No one assigned
Labels
status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tobiasdiez @lenhard