Followup to 2663 Regexformatter #3096
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…title with capitalize and title case
6 tasks
koppor
added
the
status: ready-for-review
Siedlerchr
reviewed
Aug 11, 2017
| Optional<Formatter> formatter; | ||
|
|
||
| if (modifier.matches("regex.*")) { | ||
| String regex = modifier.substring(5); |
There was a problem hiding this comment.
please define this magic number somewhere as constant
Siedlerchr
reviewed
Aug 11, 2017
| public static void setRegex(String rex) { | ||
| // formatting is like ("exp1","exp2"), we want to remove (" and ") | ||
| String rexToSet = rex; | ||
| rexToSet = rexToSet.substring(2, rexToSet.length() - 2); |
There was a problem hiding this comment.
please define this magic number as constant with a useful name, so it is clear what it does
Siedlerchr
reviewed
Aug 11, 2017
| @@ -950,6 +952,8 @@ Reference_library=Referencelibrary | |||
|
|
|||
| Refine_supergroup\:_When_selected,_view_entries_contained_in_both_this_group_and_its_supergroup=Undergruppe\:_Vis_poster_indeholdt_både_i_denne_gruppe_og_gruppe_over | |||
|
|
|||
| Regex= | |||
There was a problem hiding this comment.
Regex is the same as regular expression, I would reuse that existing translation
Siedlerchr
approved these changes
Aug 11, 2017
koppor
removed
the
status: ready-for-review
koppor
requested changes
Aug 15, 2017
| @@ -65,6 +65,8 @@ | |||
|
|
|||
| public static final List<Formatter> ALL = new ArrayList<>(); | |||
|
|
|||
| private static final int LENGTH_OF_REGEX_PREFIX = 5; | |||
There was a problem hiding this comment.
Can 5 be replaced by `"regex".length()``?
| @@ -87,7 +90,7 @@ public String getExampleInput() { | |||
| public static void setRegex(String rex) { | |||
| // formatting is like ("exp1","exp2"), we want to remove (" and ") | |||
| String rexToSet = rex; | |||
| rexToSet = rexToSet.substring(2, rexToSet.length() - 2); | |||
| rexToSet = rexToSet.substring(REMOVE_OUTER_QUOTES, rexToSet.length() - REMOVE_OUTER_QUOTES); | |||
There was a problem hiding this comment.
I would replace the first REMOVE_OUTER_QUOTES by "\"(".length() and the second one by ")\"".length(). Maybe as two variables LENGTH_OF_QUOTE_AND_OPENING_BRACE and LENGTH_OF_CLOSING_BRACE_AND_QUOTE.
LinusDietz
approved these changes
Aug 16, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Regexformatter now handles protected groups correctly. This is a followup to #2663. There, the regex modifier was introduced and a minor issue with shorttitle was fixes
gradle localizationUpdate?